Public share link requests for credentials.

[SergioBertolinSG]

Steps to reproduce

EDIT II 1. Share publicly a plain text file by link
EDIT I 2. Add a password to the public link.
3. Open the link from a different browser without being logged in.

Expected behaviour

Anonymous user can open the link.

Actual behaviour

Link redirects to the login page.

Server configuration

Operating system:
Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
master branch (8.2alpha)

Updated from an older ownCloud or fresh install:
Fresh

List of activated apps:
Default in community edition..

The content of config/config.php:

Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption:
No

Logs

Client configuration

browser
Chrome 41

[PVince81]

@SergioBertolinSG is this a regression on master ?

[PVince81]

Works for me on master (85b62c7).
Link was created in Chromium 44 and opened in Firefox 39.0.3

[SergioBertolinSG]

Yes a regression.

[PVince81]

Clear the cache maybe ?

This is not enough information to be able to reproduce or fix it.

[SergioBertolinSG]

Same problem with cache cleared. I forgot to mention that the public share has to have a password (edited in the steps).

[SergioBertolinSG]

I've fixed the problem installing the last version of Firefox.

[SergioBertolinSG]

It is still happening. It happens only with plain text files. When opening the share and entering the password a dialog for credentials appears. (And it shouldn't).
Observed on chrome and safari for ipad.

[oparoz]

Confirmed.... And it's probably because of that ¦@#°% Gallery app ;)

[oparoz]

Apparently, it's not phewww... But I still need to see if I can prevent making Ajax calls before the password is entered.

What I'm seeing in the POST request is a 307 and 2 oc_sessionPassphrase with different passwords in them.
@LukasReschke must be able to fix this :)

[oparoz]

Could be related to #18891 (double passphrase)

[SergioBertolinSG]

Still happening on master from git. Tested on safari. (Working fine in firefox)

[PVince81]

Is Safari maybe somehow auto-filling the password field ? Can you try clearing the autofill cache ?

[davitol]

I've cleaned all the browsing data, and using chrome it happens the same behaviour as @SergioBertolinSG has said.

[PVince81]

@LukasReschke are you able to reproduce this on your mac?

[nickvergessen]

Can reproduce, the issue is the preview.
For plain text files we don't show an image, but make a webdav request and write the first characters into the preview box instead of an image, which requires authentification:

[PVince81]

@oparoz is the text preview sending the password to the Webdav endpoint ?

[oparoz]

@PVince81 Yes https://github.com/owncloud/core/blob/master/apps/files_sharing/js/public.js#L120

[PVince81]

Hmm, but the password isn't appended behind the ":".

Let me check how I did it with the "move to webdav" branch.

[PVince81]

Hmm, it seems I'm not passing the password either. If the browser has a session cookie related to this public share, it should be able to reuse it when doing webdav requests.

[oparoz]

The token is used as the username. There is no password

[PVince81]

Steps to reproduce (for clarity)

1. Create a text file
2. Share text file with link
3. Set password to "test"
4. Open the link
5. Enter the password "test"

At this point the popup appears for the Webdav call.

[PVince81]

I suspect it might be related to the recent refactoring in publicwebdav to use "ServerFactory". I'll try and debug the server.

[PVince81]

Hmmm no, it looks like this never worked before.
Stable8.1 is broken too and so is v8.1.1.

[PVince81]

Hmmmmmmm it works on my Webdav branch #16902 which uses public webdav for the file list and also text preview.

I'll try and find out why it works there...

[PVince81]

Aha, this one: e6f007d

I'll make a separate PR for that

[oparoz]

👯

[PVince81]

Fix is here #19402

[oparoz]

[SergioBertolinSG]

@PVince81 This happens in stable8.1 as well. backport?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.