Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose the mount manager in the public api #17291

Merged
merged 3 commits into from
Jul 3, 2015
Merged

expose the mount manager in the public api #17291

merged 3 commits into from
Jul 3, 2015

Conversation

icewind1991
Copy link
Contributor

Part of the work of bringing #12086 to master

cc @DeepDiver1975 @PVince81

PVince81
PVince81 reviewed Jul 1, 2015
View reviewed changes
lib/public/files/mount/imountmanager.php

namespace OCP\Files\Mount;

interface IMountManager {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPDoc that explains what it is ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add @since 8.2.0

@ghost
Copy link

ghost commented Jul 1, 2015

💣 Test FAILed. 💣
nooo432

PVince81
PVince81 reviewed Jul 1, 2015
View reviewed changes
lib/public/files/mount/imountmanager.php

/**
* @param string $mountPoint
* @param string $target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPDoc

@icewind1991
Copy link
Contributor Author

Added more phpdoc

@ghost
Copy link

ghost commented Jul 1, 2015

💣 Test FAILed. 💣
nooo432

@PVince81
Copy link
Contributor

PVince81 commented Jul 1, 2015

@icewind1991 minds also fixing this ?
I had this warning recently, forgot where. Just wrote it down for 8.2:

Argument 1 passed to OC\Files\Mount\Manager::addMount() must be an instance of OC\Files\Mount\MountPoint, instance of Mock_IMountPoint_f1c5ecfe given

@karlitschek
Copy link
Contributor

makes sense 👍

@scrutinizer-notifier
Copy link

A new inspection was created.

@PVince81 PVince81 added this to the 8.2-next milestone Jul 1, 2015
@icewind1991
Copy link
Contributor Author

Argument 1 passed to OC\Files\Mount\Manager::addMount() must be an instance of OC\Files\Mount\MountPoint, instance of Mock_IMountPoint_f1c5ecfe given

I believe 57945db will fix that

@PVince81
Copy link
Contributor

PVince81 commented Jul 1, 2015

Thanks. I'll regression-test this later.
The code change looks good.

@ghost
Copy link

ghost commented Jul 1, 2015

🚀 Test PASSed.🚀
chuck

@PVince81
Copy link
Contributor

PVince81 commented Jul 3, 2015

👍 sharing, external storage still work

PVince81 pushed a commit that referenced this pull request Jul 3, 2015
Merge pull request #17291 from owncloud/mount-manager-public
f707916 
expose the mount manager in the public api
@PVince81 PVince81 merged commit f707916 into master Jul 3, 2015
@MorrisJobke MorrisJobke deleted the mount-manager-public branch July 3, 2015 06:59
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @PVince81 @karlitschek @scrutinizer-notifier