[WIP] Refactor shared storage

[icewind1991]

Since the removal of the Shared folder in oc7 the logic of the shared storage and cache can be greatly simplified.

This replaces the shared storage with a combination of 2 generic storage and cache wrappers

• \OC\Files\Storage\Wrapper\Jail: limits all access of the storage to a specific folder
• \OC\Files\Storage\Wrapper\PermissionsMask: applies a permissions mask on top of a storage

Together they form 99% of the logic behind a share (a sub directory of storage with limited permissions) and also allow dropping the ReadOnlyWrapper previously in place.

Overall this drastically reduces the amount of logic for shared storages which results in a nice performance increase.
On my local test instance this reduces the time needed for a WebDAV upload to a shared folder with ~120ms and drops the number of database queries by 103

TODO:

• Adjust unit tests
• Mount any storage inside a shared folder for the share recipient

cc @DeepDiver1975 @PVince81 @schiesbn

[PVince81]

Wow, incredible.

Not sure if Jail is the right name as it still feels a bit confusing, but I understand your intention.

[karlitschek]

Awesome!!!

[schiessle]

This sounds like a awesome improvement!

I just did a short test, re-sharing seems to be broken, I get "Sharing welcome (2).txt failed, because the file does not exist". Another interesting effect: I have a folder-re-share in my share table from before I switched to your branch. If I navigate into the re-shared folder I get the content of the data/ folder.

I'm sure you will see this issues while working on the failing unit test... Just wanted to write down what I noticed so that it doesn't get lost.

[DeepDiver1975]

bloody jenkins plugin - @icewind1991 please rebase - thx

[icewind1991]

I cant reproduce any of the failing tests locally...

[icewind1991]

Mount points inside shared folders are now correctly moved over

[PVince81]

• BUG: (with files_locking + encryption enabled) move file into subdir as non-owner

1. User1 shares non-empty dir "test" to user2
2. User2 creates "test/subdir"
3. User2 moves a file "test/test.txt" to "test/subdir"

Result: "Could not obtain lock type 2" (locking app).
Maybe some file is opened twice in a row.

[PVince81]

• BUG: move a shared folder into another must show an error message (worked on master). On this branch the ajax call doesn't return an error, but the folder also isn't physicially moved even though the UI shows so

[PVince81]

• BUG: WebDAV move between two shared folders gives 500 internal server error

1. user1 shares folder "abc" with user3
2. user2 shares folder "def" with user3
3. user3 moves file "def/test.txt" to "abc/test.txt" with WebDAV

[jospoortvliet]

We're past feature freeze, right, this should target 8.2?

[jospoortvliet]

Darth Vader is VERY angry ;-)

[PVince81]

@icewind1991 reminder to try and have this early in 8.2 😄

[PVince81]

@icewind1991 another reminder to continue this so we can have early in 8.2

[MorrisJobke]

@icewind1991 another reminder to continue this so we can have early in 8.2

Ping? Defer to 9.0?

[icewind1991]

Defer

[MorrisJobke]

@icewind1991 Can we get this in? @rullzer is maybe also happy about this ;)

[icewind1991]

Waiting for @rullzer sharing work before continuing with this

[MorrisJobke]

Waiting for @rullzer sharing work before continuing with this

Ah okay. If this is the better approach I'm fine with it :)

[jospoortvliet]

Isn't the sharing work by @rullzer in? The basics, at least...

[rullzer]

@jospoortvliet baby steps ;)

[PVince81]

Moving this major refactoring to 9.1, if it still makes sense @icewind1991 ?

CC @cmonteroluque

[rullzer]

Closing this for now.
But keeping a reminding in #22209

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.