Share tags

[ockham]

I've fixed both major issues mentioned at #10487, so I now consider this review-ready.
I'll also file a PR for contacts which is supposed to fix owncloud/contacts#38.

[LukasReschke]

Always use curly braces

[ghost]

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7613/

[LukasReschke]

@owncloud-bot Retest this please

[ghost]

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7620/

[LukasReschke]

@ockham Please take a look at the failing unit tests. Thanks.

There was 1 error:

1) Test_Tags::testInstantiateWithDefaults
Declaration of OC\Tags::delete() should be compatible with OCP\AppFramework\Db\Mapper::delete(OCP\AppFramework\Db\Entity $entity)

/var/lib/jenkins/jobs/pull-request-analyser/workspace@4/lib/private/tags.php:40
/var/lib/jenkins/jobs/pull-request-analyser/workspace@4/lib/autoloader.php:142
/var/lib/jenkins/jobs/pull-request-analyser/workspace@4/lib/private/tagmanager.php:66
/var/lib/jenkins/jobs/pull-request-analyser/workspace@4/tests/lib/tags.php:49

--


There was 1 failure:

1) Test_Files_Sharing_Api::testDefaultExpireDate
Failed asserting that 2 is identical to 1.

/var/lib/jenkins/jobs/pull-request-analyser/workspace@4/apps/files_sharing/tests/api.php:1245

[scrutinizer-notifier]

The inspection completed: 23 new issues, 9 updated code elements

[ghost]

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7631/