Share tags wip

[ockham]

Okay, I guess to get this reviewed, I need to formally submit it as a PR, even though it's not entirely finished yet.

So here's my work-in-progress branch for #3812. Tested with contacts only, but nothing contacts-specific in the code, so it should work with other apps that use tags as well.

Known issues:

• If the owner and the sharee both have a tag of the same name, there will probably some collision with unknown outcome (untested).
• If the sharee tags a contact of their own with a shared tag, that contact will be counted in the owner's tagged items count as well, i.e. in the number right to the tag's name in the left column of the Contacts app.

[ghost]

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

[ockham]

Okay, I'll fix those issues scrutinizer points out with separate commits. Comments are still welcome.

[jancborchardt]

@ockham I haven’t tested yet, but does this integrate with the existing »tag-like« mechanisms in the individual apps?

• Contacts has groups
• Calendar has categories
• News has folders
• (Music will have playlists)
• Bookmarks has tags

There should not be an additional »tags« element for these apps, but the existing means should be used for this.

[ockham]

Abso-taggin'-lutely.

[scrutinizer-notifier]

A new inspection was created.

[MorrisJobke]

If this should used by other apps, we should have a public interface.

[ockham]

There is one already: OCP\ITags. I'm just modifying its backend as to include tags for shared items (which the backend looks up on its own).

[MorrisJobke]

Okay. Never heard of that before :(

[jancborchardt]

Please review, everyone who was interested in the tags support from #3812: @alexisread @bernic @fpiraneo (and even @tanghus cause I know you will like this. :)

[ockham]

@owncloud-bot retest this please

[ockham]

Next iteration: #10679