Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire Internal Shares #11642

Closed
MTRichards opened this issue Oct 17, 2014 · 21 comments
Closed

Expire Internal Shares #11642

MTRichards opened this issue Oct 17, 2014 · 21 comments

Comments

@MTRichards
Copy link
Contributor

MTRichards commented Oct 17, 2014

As a user, I want to be able to set expiration dates on internal shares in ownCloud, separate from an expiration for external share links, so that I can control who can access my files for how long.

@schiessle
Copy link
Contributor

Back then when we discussed the behaviour of the expire date we decided against it. One reason was that it would make the share dialog quite crowded. We would need to copy the expire field for each user and group share.

cc @jancborchardt

@MTRichards MTRichards added this to the backlog milestone Oct 17, 2014
@MTRichards
Copy link
Contributor Author

@schiesbn I agree, as you state.
Just to be clear, this is a placeholder - and place for discussion. Right now, I don't think this is very high priority, but I would like to track these things here - so this issue is for tracking such a conversation.

@schiessle
Copy link
Contributor

@MTRichards That's how I understood it 😄 I just wanted to add the reasons for the decision back then to keep it in mind.

@PVince81
Copy link
Contributor

Adding @owncloud/designers for further input

@jancborchardt
Copy link
Member

Yeah, it was never intended to expire internal shares and just an error adding it.

It does make sense to expire external shares since they could go out to anyone, but internal ones ...
We should really close this issue - or do we want password protection and all that stuff for internal shares as well?

@drkmccy
Copy link

drkmccy commented Apr 17, 2015

Expiry on internal shares is something that is desired. Could it be an option that is toggled in the admin panel?

@jancborchardt
Copy link
Member

We will consider it with an upcoming rework of the sharing dialog. cc @rullzer

@tlhonmey
Copy link

To avoid cluttering the control too much, it could enforce the same expiration date for internal and external shares and just add a checkbox for if it should apply to both of them or not.

@PVince81
Copy link
Contributor

Added to planning ticket #24684 (comment)

@PVince81
Copy link
Contributor

@felixheidecke @pmaier1 need some design work as the current UI doesn't have room.

I'd suggest having the list just showing the summary info of the shares and have a "edit" button for advanced/detail edit. Creating a link would create with defaults first. If a user wants more, the "edit" button could open a dialog/panel/whatever for said share for detail editing of permissions + expiration.

@PVince81 PVince81 added the p2-high Escalation, on top of current planning, release blocker label Dec 18, 2017
@PVince81 PVince81 self-assigned this Dec 18, 2017
@PVince81
Copy link
Contributor

Assigning self for backend and API work, if required.

I can also help with JS impl if needed.

@ittrend4710
Copy link

regarding "Share too Group or User option expiration date is missing" #30396
is there a release date?
best,
mike

@PVince81
Copy link
Contributor

PVince81 commented Mar 8, 2018

there is no release date as work hasn't started yet on this feature

@ittrend4710
Copy link

#30396 was closed as duplicate of #11642
feature was implemented in older versions, has gone in actual versions, no release date for it ... what should I tell my users?

@PVince81
Copy link
Contributor

PVince81 commented Mar 8, 2018

As far as I remember the feature was not implemented in any past versions, unless we are talking about a different thing. This is why this is marked as feature request.

I've setup OC 8.1.9 locally and as you can see there is no "expiration date" function for local user shares:
image

Maybe did you use a third party app that added such feature ?

@ittrend4710
Copy link

Yes, we're talking about the same thing.

User's are telling me another story ... they're missing the feature.

I cann't check it because our system is running version x now.

no third party tool installed.

best,
mike

@PVince81
Copy link
Contributor

PVince81 commented Mar 9, 2018

@ittrend4710 often times user are confused between local shares and public link shares. Public link shares is the feature that always had expiration date and currently still have. The difference is that the user interface changed a bit: they need to click on the "Share" icon and in the sidebar on the right click on the "Public link share" tab and then "Create link". That's where they can create a link and add expiration. Please note that such links can be opened by anyone even without having an account on the system. (this was always the case).

@ittrend4710
Copy link

I'll discuss it with our users ... thanks a lot

@PVince81 PVince81 modified the milestones: development, planned Apr 3, 2018
@PVince81
Copy link
Contributor

prerequisite for UI: #30779

@PVince81
Copy link
Contributor

I'm putting this to backlog for now, will move it to development once we start directly adressing this.

@PVince81 PVince81 modified the milestones: development, backlog May 29, 2018
@PVince81 PVince81 removed the p2-high Escalation, on top of current planning, release blocker label Sep 4, 2018
@PVince81 PVince81 removed their assignment Sep 5, 2019
@pmaier1
Copy link
Contributor

pmaier1 commented Apr 20, 2020

Implemented with Server 10.4.0.

@pmaier1 pmaier1 closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests