-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expire Internal Shares #11642
Comments
Back then when we discussed the behaviour of the expire date we decided against it. One reason was that it would make the share dialog quite crowded. We would need to copy the expire field for each user and group share. |
@schiesbn I agree, as you state. |
@MTRichards That's how I understood it 😄 I just wanted to add the reasons for the decision back then to keep it in mind. |
Adding @owncloud/designers for further input |
Yeah, it was never intended to expire internal shares and just an error adding it. It does make sense to expire external shares since they could go out to anyone, but internal ones ... |
Expiry on internal shares is something that is desired. Could it be an option that is toggled in the admin panel? |
We will consider it with an upcoming rework of the sharing dialog. cc @rullzer |
To avoid cluttering the control too much, it could enforce the same expiration date for internal and external shares and just add a checkbox for if it should apply to both of them or not. |
Added to planning ticket #24684 (comment) |
@felixheidecke @pmaier1 need some design work as the current UI doesn't have room. I'd suggest having the list just showing the summary info of the shares and have a "edit" button for advanced/detail edit. Creating a link would create with defaults first. If a user wants more, the "edit" button could open a dialog/panel/whatever for said share for detail editing of permissions + expiration. |
Assigning self for backend and API work, if required. I can also help with JS impl if needed. |
regarding "Share too Group or User option expiration date is missing" #30396 |
there is no release date as work hasn't started yet on this feature |
Yes, we're talking about the same thing. User's are telling me another story ... they're missing the feature. I cann't check it because our system is running version x now. no third party tool installed. best, |
@ittrend4710 often times user are confused between local shares and public link shares. Public link shares is the feature that always had expiration date and currently still have. The difference is that the user interface changed a bit: they need to click on the "Share" icon and in the sidebar on the right click on the "Public link share" tab and then "Create link". That's where they can create a link and add expiration. Please note that such links can be opened by anyone even without having an account on the system. (this was always the case). |
I'll discuss it with our users ... thanks a lot |
prerequisite for UI: #30779 |
I'm putting this to backlog for now, will move it to development once we start directly adressing this. |
Implemented with Server 10.4.0. |
As a user, I want to be able to set expiration dates on internal shares in ownCloud, separate from an expiration for external share links, so that I can control who can access my files for how long.
The text was updated successfully, but these errors were encountered: