Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing Dialog] Simplify the user/group sharing permissions/attributes handling #5797

Closed
2 tasks
SamuAlfageme opened this issue May 29, 2017 · 6 comments
Closed
2 tasks

Comments

@SamuAlfageme
Copy link
Contributor

If in the future, more fine-grained options can be introduced in the sharing permissions/attributes via core-functionality or apps (ideally, announcing it via a corresponding capability). The permission handling on the desktop's native sharing dialog could be simplified to fit all these options while keeping it clean.

  • Remove the "can" from "can share"/"edit" for a cleaner UI (like it happens with "change", "create" and "delete")
  • Move all the extended permissions to a different "share settings" dialog, that can easily fit new check-boxes and additional options.

An initial proposal I came up with:

No extended permissions No extra actions (ext.perm. nor "additional")
no_ext_permissions no_extra_actions

cc/ @ckamm @michaelstingl @pmaier1

@SergioBertolinSG
Copy link

The way the sharing api is done currently would require different dialogs for regular shares and public shares. In public shares you can add expiration date, a password and the option of public upload.

@SamuAlfageme
Copy link
Contributor Author

@SergioBertolinSG we already have the different dialogs covered with the multitab "Share with ownCloud" (see above for "Users and Groups" and "Public Links" tabs).

This one is just about the Private share, in order to move the extended permissions or future new attributes for the share (e.g. expiration date) to a different dialog to both simplify and allow bulk edition of these. This is how it is right now:

@SergioBertolinSG
Copy link

Ah yes, didn't see it before.

Ok, adding that will require changes in the sharing api and some automated tests in core before adding it to the client.

@SamuAlfageme
Copy link
Contributor Author

SamuAlfageme commented May 31, 2017

@SergioBertolinSG yeah, owncloud/core#11642 has to happen before the expiration date gets here, into the client.

@michaelstingl
Copy link
Contributor

@SamuAlfageme @ckamm Expiration date for user/group shares planned for oC server 10.0.5: https://github.com/owncloud/enterprise/issues/2001#issuecomment-332617932

@TheOneRing
Copy link
Contributor

The sharing dialog is considered deprecated

@TheOneRing TheOneRing closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants