-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sharing Dialog] Simplify the user/group sharing permissions/attributes handling #5797
Comments
The way the sharing api is done currently would require different dialogs for regular shares and public shares. In public shares you can add expiration date, a password and the option of public upload. |
@SergioBertolinSG we already have the different dialogs covered with the multitab "Share with ownCloud" (see above for "Users and Groups" and "Public Links" tabs). This one is just about the Private share, in order to move the extended permissions or future new attributes for the share (e.g. expiration date) to a different dialog to both simplify and allow bulk edition of these. This is how it is right now: |
Ah yes, didn't see it before. Ok, adding that will require changes in the sharing api and some automated tests in core before adding it to the client. |
@SergioBertolinSG yeah, owncloud/core#11642 has to happen before the expiration date gets here, into the client. |
@SamuAlfageme @ckamm Expiration date for user/group shares planned for oC server 10.0.5: https://github.com/owncloud/enterprise/issues/2001#issuecomment-332617932 |
The sharing dialog is considered deprecated |
If in the future, more fine-grained options can be introduced in the sharing permissions/attributes via core-functionality or apps (ideally, announcing it via a corresponding capability). The permission handling on the desktop's native sharing dialog could be simplified to fit all these options while keeping it clean.
An initial proposal I came up with:
cc/ @ckamm @michaelstingl @pmaier1
The text was updated successfully, but these errors were encountered: