Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt "public link" permissions to oC server 10.0.4 UI #6192

Closed
michaelstingl opened this issue Nov 27, 2017 · 11 comments
Closed

Adapt "public link" permissions to oC server 10.0.4 UI #6192

michaelstingl opened this issue Nov 27, 2017 · 11 comments
Assignees
Labels
Design & UX feature:sharing p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Nov 27, 2017

UI for "public link" permissions has been improved with oC server 10.0.4:
owncloud/core#29376

bildschirmfoto vom 2017-10-27 16-30-06

@ckamm What is the effort to bring this to the desktop client? /cc @guruz @ogoffart @SamuAlfageme

@ogoffart
Copy link
Contributor

I don't think it is too difficult. But this would still be something we would only do in 2.5, right? (because otherwise it would delay the 2.4 release)

(I'm wondering if it would not be better to open the browser to share instead of having a native dialog, that way we always have the same ui. (but that would need a decent single sign on mechanism))

@pmaier1 pmaier1 changed the title Adapt "private link" permissions to oC server 10.0.4 UI Adapt "public link" permissions to oC server 10.0.4 UI Nov 28, 2017
@SamuAlfageme
Copy link
Contributor

@ogoffart 👍 for 2.5, no need to rush this over 2.4

(I'm wondering if it would not be better to open the browser to share instead of having a native dialog, that way we always have the same ui.

I wonder the same; see comments in #5796 and #5797. However, I like the minimalist approach of client's native sharing dialog and all @ckamm's nice redesigns for 2.4/2.5 (meaning I'd still keep it for straightforward tasks)

(but that would need a decent single sign on mechanism))

yup: #633 was one of my main ideas for the upcoming ownCloud hackweek

@SamuAlfageme SamuAlfageme added this to the 2.5.0 milestone Nov 28, 2017
@michaelstingl
Copy link
Contributor Author

we would only do in 2.5, right?

yes

decent single sign on mechanism

==> next week 😉

@ckamm
Copy link
Contributor

ckamm commented Nov 29, 2017

It's a minor change.

Fwiw, I'd be perfectly fine with replacing the native UI if we can make it work reliably and smoothly for the user.

@pmaier1
Copy link

pmaier1 commented Apr 6, 2018

Sorry to open this again but we refined the wording for the web interface and I would like to adapt this for the next client release as well:

  • Download / View
    Recipients can view or download contents.
  • Download / View / Upload
    Recipients can view, download, edit, delete and upload contents.
  • Upload only (File Drop)
    Receive files from multiple recipients without revealing the contents of the folder.

link_share_permissions

@pmaier1 pmaier1 reopened this Apr 6, 2018
@michaelstingl
Copy link
Contributor Author

For comparison: This was planned for 2.5:

oC server 10.0.4 (was) planned for 2.5
oC server 10.0.4 planned for 2.5

@pmaier1
Copy link

pmaier1 commented Apr 6, 2018

@michaelstingl looks good, so only wording change 👍 Please don't call the headline "Link properties". Can we agree on just having Permissions?

@michaelstingl
Copy link
Contributor Author

@pmaier1 Changing again is pain, but I also prefer the new wording for non-tech users.

@ckamm I'm very sorry, but could you do your magic once again for us? Thanks!

@guruz guruz added p2-high Escalation, on top of current planning, release blocker and removed ReadyToTest QA, please validate the fix/enhancement labels Apr 6, 2018
@ckamm
Copy link
Contributor

ckamm commented Apr 6, 2018

It's a straightforward change, sure :)

@pmaier1
Copy link

pmaier1 commented Apr 6, 2018

Please don't call the headline "Link properties". Can we agree on just having Permissions?

(Or just remove the headline as there is none in the WebUI as well)

It's a straightforward change, sure :)

👍

@jnweiger
Copy link
Contributor

jnweiger commented Aug 9, 2018

Pretty accurate in 250beta1 with compared to the update from @pmaier1 above:
grafik

checked on win10 and ubuntu18 with nautilus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design & UX feature:sharing p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

7 participants