ci: build with crash reporter, auto updater and appimage updater #11975
Conversation
|
that did not work ..... |
.github/workflows/main.yml
Outdated
| } | ||
| if ("${{ matrix.target }}" -eq "linux-gcc-x86_64" ) { | ||
| # build with appimage updater and others | ||
| & "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c --set args="-DWITH_CRASHREPORTER=ON -DWITH_AUTO_UPDATER=ON -DWITH_APPIMAGEUPDATER=ON" owncloud/owncloud-client |
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| & "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c --install-deps owncloud/owncloud-client |
There was a problem hiding this comment.
On Linux I run:
craft --set enableAppImageUpdater=True owncloud-client
before installing the deps. Then CMake will pick up the package, and turn that feature on without needing extra -D flags.
There was a problem hiding this comment.
does something similar exist for crash reporter and auto updater? @erikjv
There was a problem hiding this comment.
that is also not working - no trace of appimageupdater.cpp being compiled ....
There was a problem hiding this comment.
does something similar exist for crash reporter and auto updater? @erikjv
craft --search owncloud-client gives all the options, and yes there are options for that
DeepDiver1975
force-pushed
the
ci/compile-with-more-features
branch
2 times, most recently
from
ad42998
to
0867ee9
Compare
DeepDiver1975
force-pushed
the
ci/compile-with-more-features
branch
from
0867ee9
to
c4dad84
Compare
DeepDiver1975
force-pushed
the
ci/compile-with-more-features
branch
from
c4dad84
to
091d5f0
Compare
DeepDiver1975
changed the title
|
🎉 |
|
@erikjv using --set sent me on the right track - thx |
| } | ||
| if ("${{ matrix.target }}" -eq "linux-64-gcc" ) { | ||
| # build with appimage updater and others | ||
| & "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c --set enableAppImageUpdater=true owncloud-client |
There was a problem hiding this comment.
Do you need to do this again? This is already done in the Install dependencies step.
There was a problem hiding this comment.
it has to be done again to have the env properly setup - at least this is the way I understood this.
No description provided.