Fix AppImageUpdater build #11971
Merged
Fix AppImageUpdater build #11971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a build step to the GitHub workflows to build the app image so that we prevent similar issues in the future? |
|
BTW this is wrong |
brilliant - this is why I want this to be compiled on ci .... |
DeepDiver1975
requested changes
Nov 8, 2024
erikjv
force-pushed
the
work/fix-linux-build
branch
from
481264a
to
6042420
Compare
I removed the method declaration, as I wrote in the new commit message: The method |
erikjv
force-pushed
the
work/fix-linux-build
branch
from
6042420
to
78fc97d
Compare
|
(I fixed the commit message in the last push) |
|
cherry-picked ci change from #11975 to see it truly compiling it now ... |
|
compiler issue gone - but the package step is now failing .... Monday 👋 |
The method `handleStartup` was renamed to `validateUpdate`, and is now handled in the `Updater` base class. The `AppImageUpdater` does not need to override it.
DeepDiver1975
force-pushed
the
work/fix-linux-build
branch
from
f4c94b1
to
b929fa3
Compare
DeepDiver1975
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.