Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused command line option --language #11270

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Oct 9, 2023

This option was used before the UI language could be chosen in the settings.

Fixes: #11245

Todo: changelog entry

@erikjv erikjv self-assigned this Oct 9, 2023
@erikjv erikjv marked this pull request as draft October 9, 2023 14:57
@erikjv erikjv changed the title Remove command line option --language Remove unused command line option --language Oct 9, 2023
@fmoc
Copy link
Contributor

fmoc commented Oct 10, 2023

Personally, I'd like to keep this parameter, see #11245 (comment).

This option was used before the UI language could be chosen in the
settings.

Fixes: #11245
@erikjv erikjv force-pushed the work/remove-language-cmdline-option branch from fc8a078 to c0467ab Compare October 10, 2023 13:00
@erikjv erikjv marked this pull request as ready for review October 10, 2023 13:01
@erikjv erikjv requested review from TheOneRing and fmoc October 10, 2023 13:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit 3cbe0f7 into master Oct 13, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/remove-language-cmdline-option branch October 13, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --language option does not work
3 participants