Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The --language option does not work #11245

Closed
erikjv opened this issue Sep 28, 2023 · 4 comments · Fixed by #11270
Closed

The --language option does not work #11245

erikjv opened this issue Sep 28, 2023 · 4 comments · Fixed by #11270
Milestone
Desktop 6.0

Comments

@erikjv
Copy link
Collaborator

erikjv commented Sep 28, 2023

The value is read from the command-line options, but it is never used.

The question is if we still need it. It was there before there was the possibility to choose a different language in the UI. So on top of that, do we need the command-line option to override both the UI-configured language and the system language?

See also issue #11142 .
@erikjv erikjv mentioned this issue Sep 28, 2023
Closed
@erikjv
Copy link
Collaborator Author

erikjv commented Sep 28, 2023

The value should have been passed to the Application class when it is constructed, and stored in the _userEnforcedLanguage member field (which is currently never set).

@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Sep 28, 2023
@erikjv erikjv mentioned this issue Oct 9, 2023
Merged
erikjv added a commit that referenced this issue Oct 9, 2023
@erikjv
Remove command line option --language
fc8a078 
This option was used before the UI language could be chosen in the
settings.

Fixes: #11245

Todo: changelog entry
@fmoc
Copy link
Contributor

fmoc commented Oct 10, 2023

I use it as part of my development cycle in order to start the client with different languages. I think this should be kept.

erikjv added a commit that referenced this issue Oct 10, 2023
@erikjv
Remove unused command line option --language
c0467ab 
This option was used before the UI language could be chosen in the
settings.

Fixes: #11245
TheOneRing pushed a commit that referenced this issue Oct 13, 2023
@erikjv @TheOneRing
Remove unused command line option --language
3cbe0f7 
This option was used before the UI language could be chosen in the
settings.

Fixes: #11245
@HanaGemela
Copy link
Contributor

HanaGemela commented Oct 16, 2023 •
edited
Loading

Removed in ownCloud 6.0.0.12402-daily20231016 ✅
@fmoc please discuss proper implementation of this parameter with @michaelstingl if needed

@fmoc
Copy link
Contributor

fmoc commented Oct 16, 2023

We decided on removing it as there are other means of changing the language for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging a pull request may close this issue.

Remove unused command line option --language owncloud/client
4 participants
@erikjv @TheOneRing @HanaGemela @fmoc