-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress in settings: Reduce update interval of remaining time #3014
Comments
This (maybe) took a big amount of CPU on @nickvergessen 's machine. |
Note that my refactoring in #2328 already introduces a 1s timer for updating the estimates. I don't think it changes the mechanism with which the estimates are pushed to the ui though, so it'll likely still happen with each transmissionProgress() emission - too often. |
I'll check if I can do this for 1.8.1 in a way that doesn't gratuitously conflict with the refactoring. |
I did the change in ffd6c62, but at least on linux not many progress updates get skipped. |
I'm not happy with this kind of fix, since it may skip interesting updates. There's also a second slot connected to the progress info update that'd need throttling. We also fixed other bugs that had a much stronger performance impact. We'll revisit this once progress reporting has been further overhauled. |
Closing old issue. |
There is no need to update the remaining time 10 times per second (or even much), because you cannot read it then, because it alwas changes. 2 update sper second should be fully enough.
cc @guruz
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9951036-progress-in-settings-reduce-update-interval-of-remaining-time?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github).The text was updated successfully, but these errors were encountered: