Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress in settings: Reduce update interval of remaining time #3014

Closed
MorrisJobke opened this issue Mar 24, 2015 · 6 comments
Closed

Progress in settings: Reduce update interval of remaining time #3014

MorrisJobke opened this issue Mar 24, 2015 · 6 comments
Assignees
Labels

Comments

@MorrisJobke
Copy link
Contributor

MorrisJobke commented Mar 24, 2015

There is no need to update the remaining time 10 times per second (or even much), because you cannot read it then, because it alwas changes. 2 update sper second should be fully enough.

cc @guruz

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9951036-progress-in-settings-reduce-update-interval-of-remaining-time?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github).
@guruz guruz changed the title Reduce update interval of remaining time Progress in settings: Reduce update interval of remaining time Mar 24, 2015
@guruz guruz added this to the 1.8.1 - Bugfix milestone Mar 24, 2015
@guruz
Copy link
Contributor

guruz commented Mar 24, 2015

This (maybe) took a big amount of CPU on @nickvergessen 's machine.

@ckamm
Copy link
Contributor

ckamm commented Mar 25, 2015

Note that my refactoring in #2328 already introduces a 1s timer for updating the estimates. I don't think it changes the mechanism with which the estimates are pushed to the ui though, so it'll likely still happen with each transmissionProgress() emission - too often.

@ckamm ckamm self-assigned this Mar 27, 2015
@ckamm
Copy link
Contributor

ckamm commented Mar 27, 2015

I'll check if I can do this for 1.8.1 in a way that doesn't gratuitously conflict with the refactoring.

ckamm added a commit to ckamm/owncloud-client that referenced this issue Mar 27, 2015
@ckamm
Copy link
Contributor

ckamm commented Mar 27, 2015

I did the change in ffd6c62, but at least on linux not many progress updates get skipped.

@ckamm
Copy link
Contributor

ckamm commented Mar 27, 2015

I'm not happy with this kind of fix, since it may skip interesting updates. There's also a second slot connected to the progress info update that'd need throttling. We also fixed other bugs that had a much stronger performance impact. We'll revisit this once progress reporting has been further overhauled.

@ckamm ckamm modified the milestones: backlog, 1.8.1 - Bugfix Mar 27, 2015
@ckamm ckamm removed their assignment Mar 27, 2015
ckamm added a commit that referenced this issue Apr 22, 2015
This reverts commit 0f33e26.

The change was not meant to be merged, see discussion in #3014.
@guruz guruz modified the milestones: 2.0.1-next, backlog Aug 3, 2015
@guruz guruz self-assigned this Aug 17, 2015
@guruz guruz modified the milestones: 2.2-next, 2.0.1-next Aug 31, 2015
@guruz guruz removed this from the 2.2.0-current milestone Feb 22, 2016
@guruz guruz added sev4-low and removed type:bug labels Apr 14, 2016
@felixboehm felixboehm added p4-low Low priority and removed sev4-low labels May 3, 2018
@ogoffart
Copy link
Contributor

Closing old issue.
The progress impl has changed a bit since that time, and nobody is complaining anymore it is too frequent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants