time estimates shows wrong values

[moscicki]

Time estimates are very confusing in 1.7. See attached screenshot.

Several issues:

Estimated total time is smaller then estimated download of the current file. I guess it has to do with the parallel download.

Also the time estimate for the current file refreshes very quickly (and changes all the time=>completely unreliable) while the total time refreshes every second and seems more stable and reliable.

Also, Occasionally I saw some time estimates like 1y10month to complete (for very large directories, ~100K files). That was clearly wrong because in reality it took 1 hour or so.

After a while both time estimates got closer (still total<current file download time):

[enoch85]

CC @dark-eye

[ghost]

Related : #2521

[enoch85]

Related #2400

[dark-eye]

(Sorry for the late reaspone didn't see this issue until now ).

I made the current file more responsive on purpose to show the actual download/upload ratios and the total is more of an average over time (which should be the correct time)
I can make them equal and prevent a visible estimate (with "estimating..." text instead) on both total and current file until they'll have a reliable estimate but that will create a different bug that short files/updates will have no estimate at all (part of the reason i made the current file more responsive)

I`ll work on it once i get home

[ckamm]

Initial work for this has gone into the 'timing' branch.

[dark-eye]

I found a bug in my implementation that if the user connection was slow for a long time and then it sped back up it will show a very long estimate, for example:

if a user transfer a 100Mb file and it internet slowed to 8kbs for an hour and then sped up back again to 2Mbs it will show more then an hour up until 75% of the file was transferred.

the reason for that it look at the past and see that it took 1 hour to transfer 35Mb so it should take 2.5 more to transfer the rest (even though with 2mb/s it should actually take less then a minutes...

[ckamm]

Merged into master branch. There's a lot of improvements that could still be done to the time estimation code...

[Dianafg76]

I tested the bug, and the time estimates shows wrong values. So I close the bug
Desktop v1.8.2 (build 2362)