Merge pull request #203 from hannesa2/ApplySomeLintsFixes

apply some Lint fixes
owncloud · Feb 11, 2019 · 490fbde · 490fbde
2 parents 82a207c + 2f64bc0
commit 490fbde
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -2,7 +2,6 @@ buildscript {
     repositories {
         google()
         jcenter()
-        google()
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:3.3.0'

diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClient.java b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClient.java
@@ -61,12 +61,11 @@ public class OwnCloudClient extends HttpClient {
     private static final String TAG = OwnCloudClient.class.getSimpleName();
     private static final int MAX_REDIRECTIONS_COUNT = 3;
     private static final int MAX_REPEAT_COUNT_WITH_FRESH_CREDENTIALS = 1;
-    private static final String PARAM_PROTOCOL_VERSION = "http.protocol.version";
 
     private static byte[] sExhaustBuffer = new byte[1024];
     private static int sIntanceCounter = 0;
     private OwnCloudCredentials mCredentials = null;
-    private int mInstanceNumber = 0;
+    private int mInstanceNumber;
     private Uri mBaseUri;
     private OwnCloudVersion mVersion = null;
     private OwnCloudAccount mAccount;
@@ -330,16 +329,16 @@ private void logSetCookiesAtResponse(Headers headers) {
     }
 
     public String getCookiesString() {
-        String cookiesString = "";
+        StringBuilder cookiesString = new StringBuilder();
         List<Cookie> cookieList = getCookiesFromUrl(HttpUrl.parse(mBaseUri.toString()));
 
         if (cookieList != null) {
             for (Cookie cookie : cookieList) {
-                cookiesString += cookie.toString() + ";";
+                cookiesString.append(cookie.toString()).append(";");
             }
         }
 
-        return cookiesString;
+        return cookiesString.toString();
     }
 
     public void setCookiesForCurrentAccount(List<Cookie> cookies) {