Added Chat Client and Canvas modules #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Referenced in app.js as 'window.canvas' as the chat client is referenced.
|
Looks great, I'm sure it'll help a lot :) |
|
👍 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I have moved the Chat Client and Canvas objects and their respective functions into their own files, called "chat-client.js" and "canvas.js". This is in contrast to the current model with both of these objects defined in the global "app.js" code. I think that doing this will make it easier for incoming developers to be able to work with the current code as well as for us to test functionality in specific parts of the project without breaking others.
I plan to refactor more of the code and hopefully will be able to successfully break down the project into very simple components (game logic, chat client, game canvas, controls, relevant constants, etc.). I think overall this would make the project more welcoming to developers who want to use the code.
Please let me know if there's anything I should structure differently, rename, etc.
Thanks once again for contributing!