Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization #424

Open
aadilzbhatti opened this issue May 27, 2016 · 2 comments
Open

Modularization #424

aadilzbhatti opened this issue May 27, 2016 · 2 comments

Comments

@aadilzbhatti
Copy link
Contributor

aadilzbhatti commented May 27, 2016

I think it would be a good idea to break this project up into separate modules to ease the process of development/testing and also make it easier for incoming developers to be able to understand the project. I have already begun doing this in #421, #422, and #423 but I think there is more to be done. I foresee the project having one "main" module where the overall game is ran, including all other modules, and the set of modules which control the different components of the game (game logic, chat client, canvas, socket handlers, etc).

@abalabahaha
Copy link
Collaborator

abalabahaha commented May 27, 2016

Thanks for contributing! I do agree that separating functionality into different modules is easier to understand/work with than a large mixed JS file.

Also, I would suggest that If you're going to continue work on modularization, I think it would be better to make one larger pull request with a big batch of commits rather than a bunch of small PRs.

@aadilzbhatti
Copy link
Contributor Author

No problem! And will do. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants