Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube/node pool upgrade parameters #272

Merged
merged 13 commits into from
Jul 25, 2022

Conversation

matprig
Copy link
Contributor

@matprig matprig commented Jul 5, 2022

Hello,

This PR contains:

  • nodepool missing parameters
  • update autoscale parameter versus destroy
  • test acceptance
    best,

ovh/resource_cloud_project_kube_nodepool_test.go Outdated Show resolved Hide resolved
ovh/resource_cloud_project_kube_nodepool_test.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/resource_cloud_project_kube_nodepool_test.go Outdated Show resolved Hide resolved
ovh/resource_cloud_project_kube_nodepool_test.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/types_cloud_project_kube_nodepool.go Outdated Show resolved Hide resolved
ovh/types_cloud.go Outdated Show resolved Hide resolved
@scraly
Copy link
Collaborator

scraly commented Jul 20, 2022

$ make testacc TESTARGS="-run TestAccCloudProjectKubeNodePool_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccCloudProjectKubeNodePool_basic -timeout 240m
?   	github.com/ovh/terraform-provider-ovh	[no test files]
=== RUN   TestAccCloudProjectKubeNodePool_basic
--- PASS: TestAccCloudProjectKubeNodePool_basic (562.85s)
    provider_test.go:218: Read Cloud Project /cloud/project/a212a1e43b614c4ba27a247b890fcf59 -> status: 'ok', desc: 'xxx_xxxxx_xxx'
PASS
ok  	github.com/ovh/terraform-provider-ovh/ovh	564.035s
?   	github.com/ovh/terraform-provider-ovh/ovh/helpers	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode	0.271s [no tests to run]
$ make testacc TESTARGS="-run TestAccCloudProjectKubeEmptyVersion_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccCloudProjectKubeEmptyVersion_basic -timeout 240m
?   	github.com/ovh/terraform-provider-ovh	[no test files]
=== RUN   TestAccCloudProjectKubeEmptyVersion_basic
--- PASS: TestAccCloudProjectKubeEmptyVersion_basic (293.14s)
    provider_test.go:218: Read Cloud Project /cloud/project/a212a1e43b614c4ba27a247b890fcf59 -> status: 'ok', desc: 'xxxx_xxx_xxx'
PASS
ok  	github.com/ovh/terraform-provider-ovh/ovh	294.327s
?   	github.com/ovh/terraform-provider-ovh/ovh/helpers	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode	0.447s [no tests to run]

✔🙂

@scraly scraly self-requested a review July 25, 2022 14:05
Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After several tests, it's OK for me :)

@scraly scraly merged commit a21848f into ovh:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants