Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Adding Labels & Taint on nodepool creation #267

Closed
rverchere opened this issue Jun 28, 2022 · 3 comments
Closed

Feature Request: Adding Labels & Taint on nodepool creation #267

rverchere opened this issue Jun 28, 2022 · 3 comments

Comments

@rverchere
Copy link

Hi there,

this would be very usefull if we can add labels and taints on nodes at creation time using terraform.
For now, I have to manually add this with kubectl.

Terraform Version

❯ terraform -v                
Terraform v1.2.0
on linux_amd64
+ provider registry.terraform.io/gavinbunney/kubectl v1.14.0
+ provider registry.terraform.io/hashicorp/helm v2.5.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.9.0
+ provider registry.terraform.io/hashicorp/local v2.2.3
+ provider registry.terraform.io/ovh/ovh v0.18.1
+ provider registry.terraform.io/rancher/rancher2 v1.23.0
+ provider registry.terraform.io/terraform-provider-openstack/openstack v1.47.0

Affected Resource(s)

  • ovh_cloud_project_kube_nodepool

Terraform Configuration Files

# Add more pool - GitLab CI
resource "ovh_cloud_project_kube_nodepool" "specific_pool" {
  service_name  = var.ovh_service_name
  kube_id       = module.kubernetes-ovh-cluster.kube_id
  name          = "my-specific-pool-1"
  flavor_name   = "b2-60"
  desired_nodes = 2
  max_nodes     = 2
  min_nodes     = 2
}
@matprig
Copy link
Contributor

matprig commented Jul 8, 2022

Hello,

i have made a PR for that #272

best

@scraly
Copy link
Collaborator

scraly commented Jul 27, 2022

Hi @rverchere ,
this feature will be added in. the next release 🙂

@scraly
Copy link
Collaborator

scraly commented Jul 28, 2022

The new 0.19.* release includes this feature :)

@scraly scraly closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants