improve Bun.stringWidth's algorithm #1738
nektrobun-windows.yml
on: pull_request
Matrix: Codegen
Matrix: Dependencies
Matrix: Zig Build
Matrix: C++ Build
Matrix: Link
Matrix: Test
Annotations
10 errors and 1 warning
|
error: Bun crashed during build:
test\bundler\expectBundled.ts#L760
at C:\a\bun\bun\test\bundler\expectBundled.ts:760:19
at C:\a\bun\bun\test\bundler\expectBundled.ts:475:11
|
|
error: expect(received).toBe(expected):
test\cli\hot\hot.test.ts#L194
Expected: 1
Received: 0
at C:\a\bun\bun\test\cli\hot\hot.test.ts:194:5
|
|
TypeError: undefined is not an object:
..\..\..\..\C:\a\bun\bun#L1
at readableByteStreamControllerShouldCallPull (:1:21)
at readableByteStreamControllerCallPullIfNeeded (:1:21)
at :18:251
|
|
TypeError: undefined is not an object:
..\..\..\..\C:\a\bun\bun#L1
at readableByteStreamControllerShouldCallPull (:1:21)
at readableByteStreamControllerCallPullIfNeeded (:1:21)
at :18:251
|
|
error: expect(received).toBe(expected):
test\cli\install\bun-pm.test.ts#L352
Expected: 0
Received: 1
at C:\a\bun\bun\test\cli\install\bun-pm.test.ts:352:3
at C:\a\bun\bun\test\cli\install\bun-pm.test.ts:339:22
|
|
TypeError: undefined is not an object:
..\..\..\..\C:\a\bun\bun#L1
at readableByteStreamControllerShouldCallPull (:1:11)
at readableByteStreamControllerCallPullIfNeeded (:1:11)
at :18:126
|
|
error: expect(received).toBe(expected):
test\cli\install\bun-run.test.ts#L86
Expected: ""
Received: "\nPanic: Do not call watch() on windows\n\nbun has crashed :'(\n\n----- bun meta -----\nBun v1.0.29-canary.33 (3657b467) Windows x64 \nAutoCommand: \nElapsed: 7ms | User: 15ms | Sys: 0ms\nRSS: 59.11MB | Peak: 59.11MB | Commit: 78.84MB | Faults: 14580\n----- bun meta -----\n\nSearch GitHub issues https://bun.sh/issues or join in #windows channel in https://bun.sh/discord\n\nthread 4456 panic: Do not call watch() on windows\n???:?:?: 0x7ff7eca755fe in ??? (bun.exe)\n???:?:?: 0x7ff7ecbffbe9 in ??? (bun.exe)\n???:?:?: 0x7ff7ec96c410 in ??? (bun.exe)\n???:?:?: 0x7ff7ec84acf1 in ??? (bun.exe)\n???:?:?: 0x7ff7ec96b359 in ??? (bun.exe)\n???:?:?: 0x7ff7ec84acf1 in ??? (bun.exe)\n???:?:?: 0x7ff7ec96b359 in ??? (bun.exe)\n???:?:?: 0x7ff7ec96ad51 in ??? (bun.exe)\n???:?:?: 0x7ff7ec6ae40f in ??? (bun.exe)\n???:?:?: 0x7ff7ec2681f0 in ??? (bun.exe)\n???:?:?: 0x7ff7ec123610 in ??? (bun.exe)\n???:?:?: 0x7ff7ec1274fa in ??? (bun.exe)\n???:?:?: 0x7ff7ec135d48 in ??? (bun.exe)\n???:?:?: 0x7ff7ec13f121 in ??? (bun.exe)\n???:?:?: 0x7ff7ebeb159f in ??? (bun.exe)\n???:?:?: 0x7ff7ee928683 in ??? (bun.exe)\n???:?:?: 0x7ffbb3104caf in ??? (KERNEL32.DLL)\n???:?:?: 0x7ffbb3ece8aa in ??? (ntdll.dll)\n"
at C:\a\bun\bun\test\cli\install\bun-run.test.ts:86:9
|
|
error: expect(received).toBe(expected):
test\cli\install\bun-run.test.ts#L141
Expected: ""
Received: " 0 [main] bash 882 cygwin_exception::open_stackdumpfile: Dumping stack trace to bash.exe.stackdump\n"
at C:\a\bun\bun\test\cli\install\bun-run.test.ts:141:11
at C:\a\bun\bun\test\cli\install\bun-run.test.ts:127:43
|
|
error: expect(received).toBe(expected):
test\cli\install\bun-run.test.ts#L141
Expected: ""
Received: " 0 [main] bash 648 cygwin_exception::open_stackdumpfile: Dumping stack trace to bash.exe.stackdump\n"
at C:\a\bun\bun\test\cli\install\bun-run.test.ts:141:11
at C:\a\bun\bun\test\cli\install\bun-run.test.ts:127:43
|
|
error: expect(received).toBe(expected):
test\cli\install\bun-run.test.ts#L282
Expected: ""
Received: "error: Cannot find package \"[email protected]\" from \"C:\\Users\\runneradmin\\AppData\\Local\\Temp\\bun-run.test.333bkZJrX3n\\test.js\"\n"
at C:\a\bun\bun\test\cli\install\bun-run.test.ts:282:3
|
|
Test (haswell, x86_64)
embed description must be shorter than 2048, got 2118
### ❌🪟 [improve Bun.stringWidth's algorithm](https://github.com/oven-sh/bun/pull/9022)
@nektro, there are **38 test regressions** on Windows x86_64
- `test\bundler\bundler_edgecase.test.ts`
- `test\cli\hot\hot.test.ts`
- `test\cli\run\require-cache.test.ts`
- `test\cli\run\transpiler-cache.test.ts`
- `test\js\bun\dns\resolve-dns.test.ts`
- `test\js\bun\http\fetch-file-upload.test.ts`
- `test\js\bun\shell\bunshell-file.test.ts`
- `test\js\bun\shell\shelloutput.test.ts`
- `test\js\bun\shell\throw.test.ts`
- `test\js\deno\fetch\response.test.ts`
- `test\js\bun\http\bun-server.test.ts`
- `test\js\node\dns\node-dns.test.js`
- `test\js\node\env-windows.test.ts`
- `test\js\node\process\process-args.test.js`
- `test\js\node\process\process.test.js`
- `test\js\node\util\node-inspect-tests\parallel\util-inspect.test.js`
- `test\js\node\worker_threads\worker_threads.test.ts`
- `test\js\third_party\body-parser\express-body-parser-test.test.ts`
- `test\js\third_party\jsonwebtoken\issue_147.test.js`
- `test\js\third_party\socket.io\socket.io-close.test.ts`
- `test\js\third_party\socket.io\socket.io-connection-state-recovery.test.ts`
- `test\js\third_party\socket.io\socket.io-handshake.test.ts`
- `test\js\third_party\socket.io\socket.io-messaging-many.test.ts`
- `test\js\third_party\socket.io\socket.io-middleware.test.ts`
- `test\js\third_party\socket.io\socket.io-namespaces.test.ts`
- `test\js\third_party\socket.io\socket.io-server-attachment.test.ts`
- `test\js\third_party\socket.io\socket.io-socket-middleware.test.ts`
- `test\js\third_party\socket.io\socket.io-socket-timeout.test.ts`
- `test\js\third_party\socket.io\socket.io-utility-methods.test.ts`
- `test\js\third_party\socket.io\socket.io.test.ts`
- `test\js\web\fetch\body.test.ts`
- `test\js\web\fetch\body-stream.test.ts`
- `test\js\web\fetch\fetch.test.ts`
- `test\js\web\timers\performance.test.js`
- `test\js\web\timers\setTimeout.test.js`
- `test\js\web\websocket\websocket.test.js`
- `test\regression\issue\08095.test.ts`
- `test\js\web\workers\worker.test.ts`
[Full Test Output](https://github.com/oven-sh/bun/actions/runs/8013339611)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
bun-windows-x64
Expired
|
31.3 MB |
|
|
bun-windows-x64-baseline
Expired
|
31.3 MB |
|
|
bun-windows-x64-baseline-profile
Expired
|
97.9 MB |
|
|
bun-windows-x64-codegen
Expired
|
1000 KB |
|
|
bun-windows-x64-cpp
Expired
|
181 MB |
|
|
bun-windows-x64-cpp-baseline
Expired
|
181 MB |
|
|
bun-windows-x64-deps
Expired
|
9.74 MB |
|
|
bun-windows-x64-deps-baseline
Expired
|
9.74 MB |
|
|
bun-windows-x64-profile
Expired
|
97.9 MB |
|
|
bun-windows-x64-zig
Expired
|
19.2 MB |
|
|
bun-windows-x64-zig-baseline
Expired
|
19.1 MB |
|