Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Bun.stringWidth's algorithm #9022

Merged
merged 17 commits into from
Feb 23, 2024
Merged

improve Bun.stringWidth's algorithm #9022

merged 17 commits into from
Feb 23, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented Feb 21, 2024

previous one was not parsing out the ansi escape codes at all

Copy link
Contributor

github-actions bot commented Feb 21, 2024

@nektro 2 files with test failures on linux-x64-baseline:

View test output

#3657b4672579e0fbc452a7abc30a02ae50eb2533

Copy link
Contributor

github-actions bot commented Feb 21, 2024

@nektro 1 files with test failures on linux-x64:

View test output

#3657b4672579e0fbc452a7abc30a02ae50eb2533

Copy link
Contributor

github-actions bot commented Feb 21, 2024

❌🪟 @nektro, there are 38 test regressions on Windows x86_64

  • test\bundler\bundler_edgecase.test.ts
  • test\cli\hot\hot.test.ts
  • test\cli\run\require-cache.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\dns\resolve-dns.test.ts
  • test\js\bun\http\fetch-file-upload.test.ts
  • test\js\bun\shell\bunshell-file.test.ts
  • test\js\bun\shell\shelloutput.test.ts
  • test\js\bun\shell\throw.test.ts
  • test\js\deno\fetch\response.test.ts
  • test\js\bun\http\bun-server.test.ts
  • test\js\node\dns\node-dns.test.js
  • test\js\node\env-windows.test.ts
  • test\js\node\process\process-args.test.js
  • test\js\node\process\process.test.js
  • test\js\node\util\node-inspect-tests\parallel\util-inspect.test.js
  • test\js\node\worker_threads\worker_threads.test.ts
  • test\js\third_party\body-parser\express-body-parser-test.test.ts
  • test\js\third_party\jsonwebtoken\issue_147.test.js
  • test\js\third_party\socket.io\socket.io-close.test.ts
  • test\js\third_party\socket.io\socket.io-connection-state-recovery.test.ts
  • test\js\third_party\socket.io\socket.io-handshake.test.ts
  • test\js\third_party\socket.io\socket.io-messaging-many.test.ts
  • test\js\third_party\socket.io\socket.io-middleware.test.ts
  • test\js\third_party\socket.io\socket.io-namespaces.test.ts
  • test\js\third_party\socket.io\socket.io-server-attachment.test.ts
  • test\js\third_party\socket.io\socket.io-socket-middleware.test.ts
  • test\js\third_party\socket.io\socket.io-socket-timeout.test.ts
  • test\js\third_party\socket.io\socket.io-utility-methods.test.ts
  • test\js\third_party\socket.io\socket.io.test.ts
  • test\js\web\fetch\body.test.ts
  • test\js\web\fetch\body-stream.test.ts
  • test\js\web\fetch\fetch.test.ts
  • test\js\web\timers\performance.test.js
  • test\js\web\timers\setTimeout.test.js
  • test\js\web\websocket\websocket.test.js
  • test\regression\issue\08095.test.ts
  • test\js\web\workers\worker.test.ts

Full Test Output

Copy link
Contributor

github-actions bot commented Feb 22, 2024

@nektro 1 files with test failures on bun-darwin-aarch64:

View test output

#3657b4672579e0fbc452a7abc30a02ae50eb2533

Copy link
Contributor

github-actions bot commented Feb 22, 2024

@nektro 1 files with test failures on bun-darwin-x64:

View test output

#3657b4672579e0fbc452a7abc30a02ae50eb2533

@nektro nektro marked this pull request as ready for review February 23, 2024 01:28
@Jarred-Sumner Jarred-Sumner merged commit ed339b3 into main Feb 23, 2024
26 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-22042 branch February 23, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants