Allow default template to add custom attributes

[dnlloyd]

No description provided.

[dnlloyd]

A couple things about this commit...

The attributes I added to the .kitchen.yml are to test the minimal functionality of the customized template and customized attributes file. I wanted to verify 1)that the iterations through my device attributes behaved correctly and 2)the merge for the default attributes came together correctly. If this is overkill I can remove them.

I also ran into three issue that I did not resolve in this commit but I would like to resolve, if possible:

Issue 1: converge of customized-ubuntu-1204
ERROR: apt_package[multipath-tools]

Resolution: need to run apt-get update manually first before package resource can run successfully. A possible solution is to include the apt-get default recipe in the default multipath recipe. I have not tested this but it appears to run the apt-get update. This is also relevant to default-ubuntu-1204.

Issue 2: create customized-centos-59
default: Box 'opscode-centos-5.9' could not be found.
(https://opscode-vm-bento.s3.amazonaws.com/vagrant/virtualbox/opscode_centos-5.9_chef-provisionerless.box)

Resolution: I do not see this box at (https://opscode-vm-bento.s3.amazonaws.com/vagrant/virtualbox),perhaps it was removed. I validated that centos-510 did exist and passed existing tests in this project; can we switch to this box? This of course is also relevant to default-centos-59

Issue 3: converge customized-ubuntu-1004
Error executing action start on resource 'service[multipath-tools]'

Resolution: This version of the multipath-tools service returns 1 when the start command is issued and the service is already running (it must get started when the pkg is installed) so the service resource fails unless the service is stopped. Stopping service manually, re-running converge allows it to complete, but additional converges of course fail. This is specific to the service on Ubuntu 10.04. Changing the action of the service resource to restart would allow the cookbook to run successfully, but I think thats a bit ugly since the issue is with the multipath service, not the cookbook. Perhaps another version of Ubuntu 10 would be better to test against. I'd need to look into this.

[spion06]

I think it would be better to put this inside of a hash rather than using the if matching here.

ex:

default['multipath']['customized']['defaults']

[dnlloyd]

The logic was left-over from a previous iteration I had and I forgot to remove it. I think it would suffice to just remove the logic, don't you?

[ovaistariq]

@dnlloyd I was out on vacation and got back to work today. I am slowly catching up on my emails. I will get to this very soon.