Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6709 Allow certain admins to access inboxes #4880

Merged

Conversation

nish-shai-scacap
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6709

Purpose

  • Allows admins with the role superadmin or policy_and_abuse to access user inboxes
  • Admins cannot approve or delete comments or mark them as read/unread. They will be redirected to homepage with error if they perform these actions.

Credit

Nisha (she/her)

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (and double thanks for making things translatable!) One question and some minor suggestions for you when you have some time

spec/controllers/inbox_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/inbox_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/inbox_controller_spec.rb Outdated Show resolved Hide resolved
app/policies/dashboard_policy.rb Outdated Show resolved Hide resolved
app/controllers/application_controller.rb Show resolved Hide resolved
@sarken sarken changed the title AO3 6709 Allow certain admins to access inboxes AO3-6709 Allow certain admins to access inboxes Aug 7, 2024
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bilka2
Copy link
Contributor

Bilka2 commented Nov 25, 2024

This branch has a merge conflict, could you merge master and solve the conflict? We'd like to include this PR in a release soon.

@brianjaustin brianjaustin merged commit 634e7fe into otwcode:master Nov 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants