Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6762: Restrict access to actions on TagsController #4917

Conversation

Cesium-Ice
Copy link
Contributor

@Cesium-Ice Cesium-Ice commented Sep 17, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6762

Purpose

What does this PR do?

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

Cesium-Ice, they/them

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@Cesium-Ice Cesium-Ice marked this pull request as ready for review September 17, 2024 17:20
app/controllers/tags_controller.rb Show resolved Hide resolved
app/policies/wrangling_policy.rb Outdated Show resolved Hide resolved
spec/controllers/tags_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/tags_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/tags_controller_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a few very small things, please let me know if you have any questions about them

app/policies/wrangling_policy.rb Outdated Show resolved Hide resolved
spec/controllers/tags_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/tags_controller_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bilka2
Copy link
Contributor

Bilka2 commented Nov 25, 2024

This branch has a merge conflict, could you merge master and solve the conflict? We'd like to include this PR in a release soon.

(Sorry for the duplicate emails Cesium-Ice! I probably should've realised this would be needed beforehand.)
@brianjaustin brianjaustin merged commit a3602f8 into otwcode:master Nov 28, 2024
29 checks passed
@Cesium-Ice Cesium-Ice deleted the AO3-6762-admin-roles-restrict-access-to-actions-on-tags-controller branch November 30, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants