AO3-6522 Use standard analyzer for bookmarker and creators on bookmark search

[potpotkettle]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6522

Purpose

Change the Elasticsearch analyzer for boorkmarker and creators so that numbers in names (like "testy2") are not ignored when searching.

Testing Instructions

I think the instructions given in the Jira issue will work. When testing in a local environment, you might need to (re)index new users and bookmarks you might have to create, and activate resque.

References

n/a

Credit

Potpotkettle (they/them)

[potpotkettle]

This will make it inconsistent with other similar lines with FactoryBot.create in the same file. Should I change them as well? I think the substrings "bookmark" look aligned in the current (apparently illegal) style.

[potpotkettle]

The high-level tests added here might be an overkill for the small change in analyzers.

A unit test might be preferable, but I couldn't figure out how to do that.

[ceithir]

Out of curiosity, do you know the reason simple was used instead of standard in the first place?

[ceithir]

https://github.com/otwcode/otwarchive/wiki/Coding-Standards#user-content-Previewing_Hound_comments

You can (and should!) ignore anything that isn't related to the lines you've changed.

I thus guess there is no issue leaving the other calls as they are, for them to be fixed bit by bit in future PRs.

Also, this is not something Hound detects (dunno if that would be easy to add?), but the standard syntax for Cucumber expressions has changed, moving away from (explicit) regex:
https://github.com/otwcode/otwarchive/wiki/Automated-Testing#user-content-Our_Cucumber_Standards

[potpotkettle]

Out of curiosity, do you know the reason simple was used instead of standard in the first place?

I have no idea but it was the simple analyzer at least in 2014 and has been basically kept that way since then: #1840

[brianjaustin]

Nitpick: FactoryBot can automatically get the ID we just pass the object, which is IMO a bit clearer

Suggested change

	bookmarkable_id: work1.id,
	pseud_id: user_pseud.id)
	bookmarkable: work1,
	pseud: user_pseud)

[potpotkettle]

Thanks, this is now done.