Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4044: Search overhaul, part 1 #1840

Merged
merged 10 commits into from
Sep 15, 2014
Merged

Conversation

elzj
Copy link
Contributor

@elzj elzj commented Sep 14, 2014

Issue 4044: Search overhaul, part 1

This is just the json generation and indexing bits to send data to the new Elasticsearch cluster, with rake tasks to do a full reindex. We still need to hook it into the callbacks -> redis buffer cycle and create the new search classes.

https://code.google.com/p/otwarchive/issues/detail?id=4044

@coveralls
Copy link

Coverage Status

Coverage decreased (-37.73%) when pulling 6e402bb on elzj:search_overhaul into 50f9689 on otwcode:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-18.33%) when pulling 9a0ffc9 on elzj:search_overhaul into 50f9689 on otwcode:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.35%) when pulling f5497ca on elzj:search_overhaul into 50f9689 on otwcode:master.

)
end

# Note that the index must exist before you can set the mapping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the index's existence is a requirement, should there be a guard against trying to run this code without an index (i.e. check if it exists and create it if not, for example, or raise an exception?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try, Elasticsearch just tells you that you can't do it. It's one of their less oblique error messages, so I'm not sure it's worth catching it and raising a new one.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.37%) when pulling ae0ea64 on elzj:search_overhaul into 50f9689 on otwcode:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.36%) when pulling ab87444 on elzj:search_overhaul into 50f9689 on otwcode:master.

zz9pzza added a commit that referenced this pull request Sep 15, 2014
Issue 4044: Search overhaul, part 1
@zz9pzza zz9pzza merged commit 5b0c761 into otwcode:master Sep 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants