-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4044: Search overhaul, part 1 #1840
Conversation
) | ||
end | ||
|
||
# Note that the index must exist before you can set the mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the index's existence is a requirement, should there be a guard against trying to run this code without an index (i.e. check if it exists and create it if not, for example, or raise an exception?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you try, Elasticsearch just tells you that you can't do it. It's one of their less oblique error messages, so I'm not sure it's worth catching it and raising a new one.
Issue 4044: Search overhaul, part 1
Issue 4044: Search overhaul, part 1
This is just the json generation and indexing bits to send data to the new Elasticsearch cluster, with rake tasks to do a full reindex. We still need to hook it into the callbacks -> redis buffer cycle and create the new search classes.
https://code.google.com/p/otwarchive/issues/detail?id=4044