Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6616 Fix floating and displaced form elements in new webkit #4636

Merged
merged 4 commits into from
Jul 10, 2024
Merged

AO3-6616 Fix floating and displaced form elements in new webkit #4636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9626c9
AO3-6616 Fix issues with form clears in Safari
sarken Sep 29, 2023
210f844
AO3-6616 Use a more specific selector for targeting notes in system m…
sarken Sep 29, 2023
e05db1e
AO3-6616 Remove unnecessary clear for bookmarker notes blockquote
sarken Sep 29, 2023
966516a
AO3-6616 We only need it on dashboard now that the notes field is han…
sarken Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions public/stylesheets/site/2.0/07-interactions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,10 +682,15 @@ form.single .autocomplete + input + span.submit input[type="submit"] {
.dashboard > form {
float: left;
width: 100%;
clear: none;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for where we see the subnavigation hanging over the form.

}

.dashboard fieldset {
clear: right;
}

.dashboard form dt.landmark {
clear: both;
}

/*END== */
1 change: 0 additions & 1 deletion public/stylesheets/site/2.0/13-group-blurb.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ li.blurb:after, .blurb .blurb:after {
}

.blurb blockquote {
clear: none;
margin: 0.643em auto;
text-align: justify;
}
Expand Down
2 changes: 1 addition & 1 deletion public/stylesheets/site/2.0/22-system-messages.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ div.error {
box-shadow: 1px 1px 2px;
}

.notes {
p.notes {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notes field on the posting form was playing up because of a clear meant for notes in system messages (which are either paragraphs or unordered lists), but the notes elements also had the notes class. You'll see ul.notes already has this clear above, so we just needed to make sure it also applied to paragraphs with the notes class.

Fixing this allowed me to remove the clear from .blurb blockquote, which had the notes class in the bookmark blurb.

otwarchive/app/views/bookmarks/_bookmark_user_module.html.erb

Line 50 in f21f823

<blockquote class="userstuff notes">

clear: right;
}

Expand Down
Loading