AO3-6616 Fix floating and displaced form elements in new webkit #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarken
commented
Oct 2, 2023
| @@ -682,10 +682,15 @@ form.single .autocomplete + input + span.submit input[type="submit"] { | |||
| .dashboard > form { | |||
| float: left; | |||
| width: 100%; | |||
| clear: none; | |||
There was a problem hiding this comment.
This is for where we see the subnavigation hanging over the form.
| @@ -51,7 +51,7 @@ div.error { | |||
| box-shadow: 1px 1px 2px; | |||
| } | |||
|
|
|||
| .notes { | |||
| p.notes { | |||
There was a problem hiding this comment.
The notes field on the posting form was playing up because of a clear meant for notes in system messages (which are either paragraphs or unordered lists), but the notes elements also had the notes class. You'll see ul.notes already has this clear above, so we just needed to make sure it also applied to paragraphs with the notes class.
Fixing this allowed me to remove the clear from .blurb blockquote, which had the notes class in the bookmark blurb.
brianjaustin
approved these changes
Oct 7, 2023
|
Guess what's fixed in the new macOS and iOS! 🎉 |
|
Alas, it is not fully fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6616
Purpose
webkit did something terrible that affected the position of various form elements, most notably:
Full details are in the issue.
Testing Instructions
We'll want to test Safari 17 to make sure the issue is fixed and at least one older version of Safari, plus Firefox and Chrome (any version), to make sure we didn't break anything new.
References
I diagnose the issue in this comment.
Credit
Sarken, she/her