Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5776 Remove mention of author from download afterword #4615

Merged
merged 3 commits into from
Oct 29, 2023
Merged

AO3-5776 Remove mention of author from download afterword #4615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6155b17
AO3-5776 Remove mention of author from download afterword
Bilka2 Aug 21, 2023
e3703c3
AO3-5776 Capitalize Archive
Bilka2 Aug 21, 2023
dcd3578
AO3-5776 Change i18n to be English only for now
Bilka2 Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/downloads/_download_afterword.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@
</div>
<% end %>

<p class="message"><%= ts("Please") %> <%= link_to ts("drop by the archive and comment"), new_work_comment_url(@work) %> <%= ts("to let the author know if you enjoyed their work!") %></p>
<p class="message"><%= t(".please_comment_html", work_comment_link: link_to(t(".work_comment"), new_work_comment_url(@work))) %></p>
Bilka2 marked this conversation as resolved.
Show resolved Hide resolved
</div>
4 changes: 2 additions & 2 deletions app/views/downloads/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<%= render 'downloads/download_preface.html' %>
<%= render "downloads/download_preface" %>

<div id="chapters" class="userstuff">
<% if @chapters.size > 1 %>
Expand All @@ -14,4 +14,4 @@
<% end %>
</div>

<%= render 'downloads/download_afterword.html' %>
<%= render "downloads/download_afterword" %>
4 changes: 4 additions & 0 deletions config/locales/views/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@ en:
disable_anon: Sorry, this work doesn't allow non-Archive users to comment.
hidden: Sorry, you can't add or edit comments on a hidden work.
unrevealed: Sorry, you can't add or edit comments on an unrevealed work.
downloads:
download_afterword:
please_comment_html: Please %{work_comment_link} to let the creator know if you enjoyed their work!
work_comment: drop by the archive and comment
Bilka2 marked this conversation as resolved.
Show resolved Hide resolved
feedbacks:
new:
abuse:
Expand Down
7 changes: 7 additions & 0 deletions features/works/work_download.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,13 @@ Feature: Download a work
And "Words:" should appear before "Chapters:"
And "Chapters:" should appear before "Could be downloaded"

Scenario: Downloaded work afterword does not mention author

Given the work "Downloadable"
When I view the work "Downloadable"
And I follow "HTML"
Then I should not see "to let the author know if you enjoyed"
But I should see "to let the creator know if you enjoyed"

Scenario: Download of chaptered works includes chapters

Expand Down