Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5776 Remove mention of author from download afterword #4615

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Aug 21, 2023

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-5776

Purpose

Replace "author" with "creator" in the download afterword that encourages commenting.

Did not do the bonus because counting the work creators looked quite complicated, at least when looking at the logic that bylines do. But maybe I missed some easy way to get all of a work's creators/external creators/anon status.

Testing Instructions

See Jira.

References

#4607 for the change to downloads/show.html.erb

Credit

Bilka (he/him)

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sarken sarken merged commit d26b22a into otwcode:master Oct 29, 2023
@Bilka2 Bilka2 deleted the AO3-5776-downloads-author-to-creator branch November 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants