AO3-6587 Allow # as initial character in Ticket ID Field when editing a profile or pseud #1486
scottsdsreviewdog.yml
on: pull_request
Rubocop
1m 1s
ERB Lint runner
1m 38s
Annotations
1 error and 3 warnings
|
Rubocop
Process completed with exit code 1.
|
|
Rubocop:
app/models/concerns/justifiable.rb#L21
[rubocop] reported by reviewdog 🐶
Use a guard clause (`return if ticket_number.is_a?(Integer)`) instead of wrapping the code inside a conditional expression.
Raw Output:
app/models/concerns/justifiable.rb:21:5: C: Style/GuardClause: Use a guard clause (`return if ticket_number.is_a?(Integer)`) instead of wrapping the code inside a conditional expression.
|
|
Rubocop:
app/models/concerns/justifiable.rb#L22
[rubocop] reported by reviewdog 🐶
Consider merging nested conditions into outer `unless` conditions.
Raw Output:
app/models/concerns/justifiable.rb:22:66: C: Style/SoleNestedConditional: Consider merging nested conditions into outer `unless` conditions.
|
|
ERB Lint runner
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|