-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6587 Allow # as initial character in Ticket ID Field when editing a profile or pseud #4991
Open
scottsds
wants to merge
11
commits into
otwcode:master
Choose a base branch
from
scottsds:AO3-6587
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
suggested changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but there are some things to improve for i18n.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Dec 15, 2024
5 tasks
Bilka2
reviewed
Dec 15, 2024
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Dec 20, 2024
Bilka2
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6587
Purpose
This pull request will allow AO3 Support staffers to copy/paste Ticket ID numbers from their internal tools. This copied data often includes an "#" character, which staffers have to manually erase.
Previously, a live validation check would prevent staffers from hitting the "Update" button. Now, live validation is removed and the initial "#" is automagically stripped from the copied Ticket ID before validation.
Validation will allow an "#" in the first character position. If an "#" or any other character is in any other position, validation will fail.
Testing Instructions
Automated tests were updated to check for the above validation conditions, they can be manually checked as follows:
Instructions for Passing Validation
Instructions for Failing Validation
References
Are there other relevant issues/pull requests/mailing list discussions?
https://otwarchive.atlassian.net/browse/AO3-6156
https://otwarchive.atlassian.net/browse/AO3-4595