Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the ssid #99

Closed
claucece opened this issue Nov 6, 2018 · 9 comments
Closed

Show the ssid #99

claucece opened this issue Nov 6, 2018 · 9 comments
Assignees
Labels
enhancement importance low An issue that is not very important. If we can have it, great - if not, it's OK too

Comments

@claucece
Copy link
Member

claucece commented Nov 6, 2018

The secure session ID (SSID) is a 8-byte value. It is used to to verify (over the telephone, assuming the parties recognize each others' voices) that there is no man-in-the-middle. it should be displayed in this way, as described in the protocol:

For example, in C language, in "%08x" format. If the party transmitted the Auth-R message during 
the DAKE, then display the first 4 bytes in bold, and the second 4 bytes in non-bold. If the party
transmitted the Auth-I message instead, display the first 4 bytes in non-bold, and the second 4 bytes
in bold. If the party transmitted the Non-Interactive-Auth message during the DAKE, then display the
first 4 bytes in bold, and the second 4 bytes in non-bold. If the party received the 
Non-Interactive-Auth message instead, display the first 4 bytes in non-bold, and the second 4 bytes 
in bold.

It should be somehow shown in the UI of the plugin.

@claucece claucece added enhancement importance low An issue that is not very important. If we can have it, great - if not, it's OK too labels Nov 6, 2018
@MauroVelasco
Copy link
Contributor

Hi @claucece,

I'm showing the SSID in the following way:

i99_1

And the information about SSID is shown in a dialog, when the user click on SSID link:

i99_2

Can we show the SSID in that way?

@claucece
Copy link
Member Author

Awesome! Looks perfect!

@MauroVelasco
Copy link
Contributor

Hi @claucece,

The final version as suggested looks like this:

i99_3

claucece added a commit that referenced this issue Aug 3, 2019
@claucece
Copy link
Member Author

claucece commented Aug 3, 2019

@MauroVelasco .. check that I did in the last commit ;)

@MauroVelasco
Copy link
Contributor

Great, thks @claucece for the improvement

@MauroVelasco
Copy link
Contributor

Hi @claucece,

The option to show/hide ssid info is:

ss_config_show_ssid

Let me know if that location is fine

@pedropalau
Copy link
Member

I would recommend this option to be unchecked by default and use a more intuitive name like:

[X] Show the SSID in the conversation window

@MauroVelasco
Copy link
Contributor

This is the final screenshot of the configuration property.

ss_config_show_ssid_2

@claucece
Copy link
Member Author

claucece commented Aug 8, 2019

Perfect! Closing this ;)

@claucece claucece closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement importance low An issue that is not very important. If we can have it, great - if not, it's OK too
Projects
None yet
Development

No branches or pull requests

3 participants