Make the position coordinates consistent across data groups #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adnan-Ali-Ahmad
suggested changes
Feb 15, 2022
src/osyris/plot/direction.py
Outdated
| dir_vecs = np.array([[0., 0.], [1., 0.], [0., 1.]]) | ||
| dir_labs = {"x": "x", "y": "y"} | ||
|
|
||
| elif direction in ["top", "side"]: |
There was a problem hiding this comment.
direction.lower() ?
There was a problem hiding this comment.
I also applied it on "x", "y" and "z" strings.
nvaytet
commented
Feb 15, 2022
| zcenters = np.linspace(zmin + 0.5 * zspacing, zmax - 0.5 * zspacing, | ||
| resolution['z']) | ||
|
|
||
| if thick: |
There was a problem hiding this comment.
Note that this change is somewhat unrelated.
When no dx was specified for the map, the extent in z depended on the size of the cells, and was necessarily symmetrical around the origin.
This meant that at the point of generating a mesh of sampling, the z coords were not always zero, and woudl lead to empty patches in the final map, because the sampling points did not agree with the selection of points done further up.
Adnan-Ali-Ahmad
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a renaming of
xyzin theamrandsinkgroups toposition, which is consistent with thepartgroup.In addition, the axes on map figures now have better names:
xandyifdirection='z'pos_u,pos_vif the orientation is not aligned with the grid axesFixes #73
Fixes #74