Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename xyz to position? #73

Closed
nvaytet opened this issue Feb 9, 2022 · 2 comments · Fixed by #77
Closed

Rename xyz to position? #73

nvaytet opened this issue Feb 9, 2022 · 2 comments · Fixed by #77

Comments

@nvaytet
Copy link
Collaborator

nvaytet commented Feb 9, 2022

Currently, the position of amr cells and sink particles are named xyz.
But this is not a very good name, both in the Datagroup and for the figure axes.
(It labels the axes on a map as xyz_x and xyz_y).

  • Should we rename this to position to be consistent with the particles position field?
  • Another option would be to keep them as separate components x, y, and z instead of making them into a vector, but I don't like this as much as it makes it more difficult to re-center the domain with something like data['amr']['position'] - center (you would now have to have 3 operations instead)
@nvaytet nvaytet changed the title Labels xyz_x and xyz_y on maps Rename xyz to position? Feb 10, 2022
@rteyssier
Copy link
Collaborator

I would prefer pos_x for both gas and particle.

@nvaytet
Copy link
Collaborator Author

nvaytet commented Feb 11, 2022

position for particles just comes from the part_file_descriptor I think?
https://bitbucket.org/rteyssie/ramses/src/b7e8ff7e1c33ca9e52d2c8c59741015c7c6f0890/pm/output_part.f90#lines-76

If you change it there, I will change it here ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants