-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API #132
Merged
Merged
New API #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me conceptual issues about parents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes fundamental changes to the API of Osyris.
It is the first step towards Version 3.0.
The changes were triggered by the wish to support simulation results other than Ramses.
Many things, especially around making map plots, were very Ramses-centered. We attempt to cleanly remove this restriction here.
The main difference is that
Array
andDatagroup
no longer have a.parent
attribute, which linked them to their parent container (Datagroup
forArray
,Dataset
forDatagroup
), This was actually only needed for making map plots, when making a hydro density map required to go and get the cell sizes and positions in a different (amr
) data group. This makes many things conceptually simpler with howArray
behaves.Datagroup
is now much more like a simple python dict.We have now grouped all variables that are inside the AMR structure into a single
mesh
group. We then still havepart
andsink
groups.Making maps now works by using a new
.layer()
method on theDatagroup
which returns an object that contains everything needed to make the map (see docs for usage examples).