Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the map function for sinks and particles #99

Open
nvaytet opened this issue May 23, 2022 · 1 comment
Open

Generalize the map function for sinks and particles #99

nvaytet opened this issue May 23, 2022 · 1 comment
Milestone

Comments

@nvaytet
Copy link
Collaborator

nvaytet commented May 23, 2022

Currently, the map plotting function will only properly handle AMR-type variables (amr, hydro, rt).

It does handle plotting sink particles onto a plane, but in a strange way, with a call to a separate function at the end (_add_scatter), which does things very similar to other parts of map (distance to plane, dot products,...).

It does not handle particles.

We should make the mechanism apply to any type of layer. If the position key is found within the group, use that, if not, go into the amr group.

@nvaytet nvaytet added this to the Version 3 milestone May 24, 2024
@nvaytet
Copy link
Collaborator Author

nvaytet commented Jul 1, 2024

This should now be possible after #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant