fix param's repeat in http callback

[accestfromim]

This PR try to fix #3930 .

Line 59 in trunk/src/protocol/srs_protocol_utility.cpp, causes the repeat of the param
because in some case, tcUrl has already contained param, but argument param repeat it.
And after this line, it repeats

fullUrl += param.empty() ? "" : (param.at(0) == '?' ? param : "?" + param);

line 67 to 69 below are able to get the param, if append at line 59, it will repeat

fullUrl = fullUrl.substr(0, pos_query) // rtmp://ip/app/app2
                  + fullUrl.substr(pos_rslash) // /stream
                  + fullUrl.substr(pos_query, pos_rslash - pos_query); // ?k=v

---

TRANS_BY_GPT4

[accestfromim]

ok, now all checks have passed.

The problem is, when calling this function,

void srs_discovery_tc_url(string tcUrl, string &schema, string &host, string &vhost, string &app, string &stream, int &port, string &param)

if tcUrl contains param, the argrument param should be empty, or it will cause repeat in param
by adding a check in this function, I solved this problem, but I think the proper solution should be calling this function properly. And doing this will lead to a large amount of modifies to current code, some will bring new problem, so I didn't choose to do so.

[accestfromim]

And the same question also exist with arguement 'stream',
according to the test of this function, tcUrl shouldn't contain stream name, or streamUrl will repeat too! as shown in original issue #3930
but this problem can't be solved in the same way as the repeat of param

[winlinvip]

The function srs_discovery_tc_url is a utility function, please update the utests to cover your modification.

[accestfromim]

The function srs_discovery_tc_url is a utility function, please update the utests to cover your modification.

Thank you for replying!

Next, I would like to confirm with you what you want me to do.

My modification has passed the CI, indicating that it has passed all previous tests and has not introduced any new bugs.

My modification addresses this issue: when tcUrl contains param, passing a non-empty param does not cause param to be duplicated after calling this function.

So, when you ask me to add a test, are you referring to adding a test for the scenario where when tcUrl contains param, passing a non-empty param does not cause param to be duplicated after calling this function?

Additionally, there are tests for this utility function in the three test files trunk\src\utest\srs_utest_protocol.cpp, trunk\src\utest\srs_utest_protocol2.cpp, and trunk\src\utest\srs_utest_rtmp.cpp. Should I add this test to one of these files, or should I add it to all of them, or should I create a separate test file?

This is my first pull request, and I really hope to get your kindly guidance. Thank you very much.