Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "param" parameter is repeated in the http callback #3930

Open
757957414 opened this issue Jan 10, 2024 · 3 comments · May be fixed by #4199
Open

The "param" parameter is repeated in the http callback #3930

757957414 opened this issue Jan 10, 2024 · 3 comments · May be fixed by #4199
Assignees
@winlinvip
Labels
API HTTP-API, HTTP-Callback, etc. good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed TransByAI Translated by AI/GPT.

Comments

@757957414
Copy link

757957414 commented Jan 10, 2024 •
edited by winlinvip
Loading

Describe the bug
The parameters carried by the "on_publish" and "on_unpublish" events of the HTTP callback will be repeated when the callback is triggered.

Version
docker ossrs/srs:5
SRS/5.0.205

To Reproduce
1.docker run srs
image

  1. Adjust the SRS configuration settings (using the rtmp2rtc.conf file as a reference).
    image

3.obs starts broadcasting
image

4.Request parameter content is duplicated
image

Expected behavior
Content appears only once

TRANS_BY_GPT4
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jan 10, 2024
@winlinvip
Copy link
Member

winlinvip commented Feb 2, 2024 •
edited
Loading

It appears that improvements are necessary. URLs have always carried historical baggage, with various compatibility measures. It would be worthwhile to consider making changes in the future.

TRANS_BY_GPT4

@winlinvip winlinvip self-assigned this Mar 6, 2024
@winlinvip winlinvip added API HTTP-API, HTTP-Callback, etc. help wanted Extra attention is needed labels Mar 6, 2024
@winlinvip
Copy link
Member

Welcome to patch this.

@winlinvip winlinvip added the good first issue Easy to fix issues, good for newcomers label Mar 6, 2024
@accestfromim
Copy link

I'll working on this, thanks for providing this good-first-issue as a start point, I'll try to open a pr
soon

@accestfromim accestfromim linked a pull request Oct 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
API HTTP-API, HTTP-Callback, etc. good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix param's repeat in http callback accestfromim/srs
3 participants
@winlinvip @757957414 @accestfromim