🌱 disable more style linters for test files #3707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
linter update
What is the current behavior?
Test writers need to either satisfy the linter, workaround the linter, or add a nolint directive. For something that's more or less a style decision in tests, this is bad. See #3688 (comment)
What is the new behavior (if this is a feature change)?**
These linters are disabled, as really they're stylistic, and not important in tests. This is to some extent a followup of #2844, which disabled some already.
I also fixed a few unrelated linter warnings because it was easier to just fix the problem than add an exception because they weren't widespread:
errcheck
gosec
complained about file permissionsunconvert
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
When evaluating what linters to disable, I just counted what nolint directives are used in test files and targeted the big ones.
Note: we can't disable
govet
, because some of what it catches is important (see #2844 (comment))Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)