-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add probes to main call #3688
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
==========================================
- Coverage 76.41% 70.68% -5.73%
==========================================
Files 214 214
Lines 14628 14803 +175
==========================================
- Hits 11178 10464 -714
- Misses 2779 3715 +936
+ Partials 671 624 -47 |
7ed7abb
to
0281085
Compare
0281085
to
b64e134
Compare
b64e134
to
d050bf6
Compare
7cc4bd4
to
f9a3568
Compare
f9a3568
to
bf30105
Compare
bf30105
to
301c562
Compare
301c562
to
bdfd990
Compare
Most of the missing coverage is APIs in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this works. The CLI flag is what we want --probes
, we don't break the RunScorecard
function signature, and the behavior seems to be what we want.
But man is this hacky and fragile. A lot of the reasons are due to probe implementation, so fixing it in a followup is probably needed, and I've left some notes for me to file issues.
For now, I'm just checking on a backward compatibility question, relating to renaming package import aliases.
a0f877d
to
b69caff
Compare
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
7f2d3e8
to
41f2839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I'm just checking on a backward compatibility question, relating to renaming package import aliases.
As expected, renaming imports is purely cosmetic, won't break anything.
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?**
This is WIP to enable invoking probes via Scorecards main function.
Usage:
go run main.go --repo=github.com/ossf/scorecard --probes=notArchived,hasLicenseFile,hasOSVVulnerabilities --format=probe
Output (Manually pretty'ed):
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Tests and formatting has not been done yet.
Does this PR introduce a user-facing change?
Yes