📖 CODEOWNERS: Support distribution of code reviews via team assignments #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Individual maintainer assignments within CODEOWNERS mean that we cannot take advantage of GitHub code review distribution schemes for team review assignments. In this commit, we switch to team assignments within CODEOWNERS. A common complaint with this approach is that unless you are a part of the GitHub organization, you will not be able to view a team's membership/understand who the maintainers of a project are. To provide visibility into the maintainer list, we've added a MAINTAINERS.md here as well. Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
requested review from
azeemshaikh38,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
justaugustus
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3620 +/- ##
==========================================
- Coverage 76.09% 70.22% -5.88%
==========================================
Files 199 199
Lines 13741 13741
==========================================
- Hits 10456 9649 -807
- Misses 2674 3532 +858
+ Partials 611 560 -51 |
spencerschrock
approved these changes
Oct 27, 2023
diogoteles08
pushed a commit
to diogoteles08/scorecard
that referenced
this pull request
Nov 13, 2023
…ossf#3620) Individual maintainer assignments within CODEOWNERS mean that we cannot take advantage of GitHub code review distribution schemes for team review assignments. In this commit, we switch to team assignments within CODEOWNERS. A common complaint with this approach is that unless you are a part of the GitHub organization, you will not be able to view a team's membership/understand who the maintainers of a project are. To provide visibility into the maintainer list, we've added a MAINTAINERS.md here as well. Signed-off-by: Stephen Augustus <[email protected]> Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
…ossf#3620) Individual maintainer assignments within CODEOWNERS mean that we cannot take advantage of GitHub code review distribution schemes for team review assignments. In this commit, we switch to team assignments within CODEOWNERS. A common complaint with this approach is that unless you are a part of the GitHub organization, you will not be able to view a team's membership/understand who the maintainers of a project are. To provide visibility into the maintainer list, we've added a MAINTAINERS.md here as well. Signed-off-by: Stephen Augustus <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs update
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Individual maintainer assignments within CODEOWNERS mean that we cannot take advantage of GitHub code review distribution schemes for team review assignments.
In this commit, we switch to team assignments within CODEOWNERS.
A common complaint with this approach is that unless you are a part of the GitHub organization, you will not be able to view a team's membership/understand who the maintainers of a project are.
To provide visibility into the maintainer list, we've added a MAINTAINERS.md here as well.
Resolves the TODO comments left in #1530.
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)