Skip to content

Commit

Permalink
CODEOWNERS: Support distribution of code reviews via team assignments (
Browse files Browse the repository at this point in the history
…ossf#3620)

Individual maintainer assignments within CODEOWNERS mean that we
cannot take advantage of GitHub code review distribution schemes
for team review assignments.

In this commit, we switch to team assignments within CODEOWNERS.

A common complaint with this approach is that unless you are a part
of the GitHub organization, you will not be able to view a team's
membership/understand who the maintainers of a project are.

To provide visibility into the maintainer list, we've added a
MAINTAINERS.md here as well.

Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
  • Loading branch information
justaugustus authored and diogoteles08 committed Nov 13, 2023
1 parent 64d4608 commit a8f758f
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 7 deletions.
10 changes: 3 additions & 7 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,8 @@
# the repo. Unless a later match takes precedence,
# the following users/teams will be requested for
# review when someone opens a pull request.
# TODO(owners): For ease of management, this should eventually shift to a
# defined GitHub team instead of individual usernames
* @azeemshaikh38 @justaugustus @laurentsimon @naveensrinivasan @spencerschrock @raghavkaul
* @ossf/scorecard-maintainers

# Docs
# TODO(owners): For ease of management, this should eventually shift to a
# defined GitHub team instead of individual usernames
*.md @olivekl
/docs/ @olivekl
*.md @ossf/scorecard-doc-maintainers
/docs/ @ossf/scorecard-doc-maintainers
21 changes: 21 additions & 0 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Maintainers

## `scorecard-maintainers`

- Stephen Augustus ([@justaugustus](https://github.com/justaugustus)), Cisco
- Raghav Kaul ([@raghavkaul](https://github.com/raghavkaul)), Google
- Spencer Schrock ([@spencerschrock](https://github.com/spencerschrock)), Google
- Azeem Shaikh [@azeemshaikh38](https://github.com/azeemshaikh38), Google
- Laurent Simon ([@laurentsimon](https://github.com/laurentsimon)), Google
- Naveen Srinivasan ([@naveensrinivasan](https://github.com/naveensrinivasan)), Independent

## `scorecard-doc-maintainers`

- Kara Olive ([@olivekl](https://github.com/olivekl)), Google

## Emeritus

Former maintainers are listed here.
Thanks for your contributions to Scorecard!

-

0 comments on commit a8f758f

Please sign in to comment.