Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 convert Webhook check to probes #3522

Merged
merged 18 commits into from
Dec 5, 2023
Merged

Conversation

AdamKorcz
Copy link
Contributor

What kind of change does this PR introduce?

feature

What is the new behavior (if this is a feature change)?**

This PR converts the Webhook check to probes

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Does this PR introduce a user-facing change?

NONE


@AdamKorcz AdamKorcz temporarily deployed to gitlab September 27, 2023 16:01 — with GitHub Actions Inactive
@AdamKorcz AdamKorcz temporarily deployed to integration-test September 27, 2023 16:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #3522 (9d4aaf7) into main (c089856) will decrease coverage by 7.60%.
The diff coverage is 77.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   76.37%   68.78%   -7.60%     
==========================================
  Files         212      213       +1     
  Lines       14496    14549      +53     
==========================================
- Hits        11071    10007    -1064     
- Misses       2771     3958    +1187     
+ Partials      654      584      -70     

probes/hasWebhooks/def.yml Outdated Show resolved Hide resolved
probes/hasWebhooks/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/impl.go Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/impl.go Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/impl_test.go Outdated Show resolved Hide resolved
checks/evaluation/webhooks_test.go Show resolved Hide resolved
@AdamKorcz AdamKorcz temporarily deployed to gitlab September 29, 2023 11:31 — with GitHub Actions Inactive
@AdamKorcz AdamKorcz temporarily deployed to integration-test September 29, 2023 11:31 — with GitHub Actions Inactive
@github-actions
Copy link

Stale pull request message

Copy link

github-actions bot commented Nov 2, 2023

This pull request is stale because it has been open for 10 days with no activity

@AdamKorcz
Copy link
Contributor Author

@spencerschrock @laurentsimon I have rewritten so it no longer has the hasWebhooks probe and uses OutcomeNotApplicable instead. PTAL

@github-actions github-actions bot removed the Stale label Nov 15, 2023
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/impl.go Outdated Show resolved Hide resolved
checker/check_result_test.go Show resolved Hide resolved
checks/evaluation/webhooks.go Outdated Show resolved Hide resolved
checks/webhook.go Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/def.yml Outdated Show resolved Hide resolved
probes/webhooksWithoutTokenAuth/impl.go Outdated Show resolved Hide resolved
@AdamKorcz AdamKorcz force-pushed the webhook-probe branch 2 times, most recently from 510260d to 3c03dda Compare November 28, 2023 10:51
probes/webhooksUseSecrets/impl.go Outdated Show resolved Hide resolved
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
@spencerschrock spencerschrock enabled auto-merge (squash) December 5, 2023 18:52
@spencerschrock spencerschrock merged commit ec36916 into ossf:main Dec 5, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants