replace probe with OutcomeNotApplicable

Signed-off-by: AdamKorcz <[email protected]>
ossf · Nov 14, 2023 · 4359a93 · 4359a93
1 parent 91c15e6
commit 4359a93
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 71 deletions.
diff --git a/checks/evaluation/webhooks_test.go b/checks/evaluation/webhooks_test.go
@@ -112,77 +112,12 @@ func TestWebhooks(t *testing.T) {
 			name: "Twelve webhooks none of which have secrets",
 			findings: []finding.Finding{
 				{
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "hasWebhooks",
-					Outcome: finding.OutcomePositive,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
-					Probe:   "webhooksWithoutTokenAuth",
-					Outcome: finding.OutcomeNegative,
-				}, {
 					Probe:   "webhooksWithoutTokenAuth",
 					Outcome: finding.OutcomeNegative,
+					Values: map[string]int{
+						"totalWebhooks":         12,
+						"webhooksWithoutSecret": 12,
+					},
 				},
 			},
 			result: scut.TestReturn{

diff --git a/probes/webhooksWithoutTokenAuth/impl.go b/probes/webhooksWithoutTokenAuth/impl.go
@@ -40,9 +40,9 @@ func Run(raw *checker.RawResults) ([]finding.Finding, string, error) {
 
 	var findings []finding.Finding
 
-	if totalWebhooks == 0 {
+	if len(r.Webhooks) == 0 {
 		f, err := finding.NewWith(fs, Probe,
-			"Repository has webhook without token authorization.", nil,
+			"Repository does not have webhooks.", nil,
 			finding.OutcomeNotApplicable)
 		if err != nil {
 			return nil, Probe, fmt.Errorf("create finding: %w", err)