✨ Support Binary-Artifacts check again for local repos #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
raghavkaul
as code owners
spencerschrock
had a problem deploying
to
gitlab
GitHub Actions
Failure
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
approved these changes
Aug 22, 2023
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
- Coverage 72.67% 66.46% -6.21%
==========================================
Files 183 183
Lines 12932 12938 +6
==========================================
- Hits 9398 8599 -799
- Misses 3015 3855 +840
+ Partials 519 484 -35 |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* invert workflow check and explain early exit. Signed-off-by: Spencer Schrock <[email protected]> * make workflow run validation optional. Signed-off-by: Spencer Schrock <[email protected]> * mark binary artifacts as local file friendly. Signed-off-by: Spencer Schrock <[email protected]> * add test for gradle wrapper without workflow run support Signed-off-by: Spencer Schrock <[email protected]> * fix policy tests and make their names more clear. Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
Binary-Artifactscheck.What is the new behavior (if this is a feature change)?**
local repos can use
Binary-Artifacts, but there are no gradle-wrapper exceptions because we can't verify workflow runs locally (see ✨ Binary artifact exception for gradle-wrapper.jar when using validation action #2039)Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #3258
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)