-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow "incomplete" checks for --local repos #3832
Labels
Comments
We do this in other places already ( see #3756 and #3415): scorecard/checks/raw/dependency_update_tool.go Lines 44 to 54 in 83ff808
With that in mind, these could be accomplished with similar means:
However |
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 27, 2024
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 27, 2024
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 27, 2024
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 27, 2024
Signed-off-by: Luke Harrison <[email protected]>
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 27, 2024
Signed-off-by: Luke Harrison <[email protected]>
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 28, 2024
Signed-off-by: Luke Harrison <[email protected]>
lharrison13
added a commit
to lharrison13/scorecard
that referenced
this issue
Nov 29, 2024
Signed-off-by: Luke Harrison <[email protected]>
spencerschrock
pushed a commit
that referenced
this issue
Dec 2, 2024
* ✨ allow incomplete localdir checks (#3832) Signed-off-by: Luke Harrison <[email protected]> * ✨ fixes as per @spencerschrock (#3832) Signed-off-by: Luke Harrison <[email protected]> * ✨ fixed linting issues (#3832) Signed-off-by: Luke Harrison <[email protected]> --------- Signed-off-by: Luke Harrison <[email protected]> Signed-off-by: Luke Harrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Running scorecard with
--local
only allows it to run 6 checks. Of the 12 that aren't run, I propose that 6 be allowed to run, even if the results may be incomplete when compared with the upstream:Describe the solution you'd like
--local
, we simply don't look for OSS-Fuzz.--local
, we simply use the fallbacks.--local
repo using just the commit activity: usegit log
to detect the frequency of commits and use the date of the root commit to determine whether the repo is 90+ days old.--local
, it could skip that later step.--local
, it could simply reward for having a SAST workflow.--local
, it could just look in the repo.In all of these cases, Scorecard should log that the results are potentially incomplete/unrepresentative of the upstream repository.
The text was updated successfully, but these errors were encountered: