🐛 Ignore Bot commits when checking for Code Review #2311
Conversation
* Update clients * Update scoring Signed-off-by: Raghav Kaul <[email protected]>
* More detailed information for Changesets * If there's no Revision ID, use the Commit SHA instead Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
- Coverage 40.51% 40.39% -0.13%
==========================================
Files 112 112
Lines 8818 8858 +40
==========================================
+ Hits 3573 3578 +5
- Misses 4984 5018 +34
- Partials 261 262 +1 |
|
Integration tests success for |
| @@ -57,6 +58,13 @@ func CodeReview(name string, dl checker.DetailLogger, r *checker.CodeReviewData) | |||
| } | |||
|
|
|||
| func reviewScoreForChangeset(changeset *checker.Changeset) (score reviewScore) { | |||
| if changeset.Commits[0].Committer.IsBot { | |||
There was a problem hiding this comment.
is it right to always ignore these bots? Say, AllStar / Dependabot sends a PR to fix something.. should it be manually reviewed? Ignoring unilaterally creates a precedent that any random bots someone sets up won't need reviews.
Is there a way to distinguish?
Also, I think it's feasible for someone to set the bot name themselves when creating a PR / commit.
Shall we use the User.id instead https://github.com/raghavkaul/scorecard/blob/5b490d3e583bbb1b774a75c459caaf0496292a90/clients/user.go#L23 to identify "real" bots? I think this one cannot be forged... but should verify my claim.
If this works, shall we keep a list of "acceptable" bots? And add it to our documentation of the check?
|
Stale pull request message |
What kind of change does this PR introduce?
Ignore bot commits when checking for code review. This is an update to the evaluation logic as well as clients. It checks for Bots without relying solely on committer names.
What is the current behavior?
Today, bot commits that are pushed directly to the default branch are considered unreviewed.
Which issue(s) this PR fixes
Fixes #2302
Special notes for your reviewer
Raw result format is also updated.