Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Code Review Check handle commits made by version bump bots #2302

Closed
joycebrum opened this issue Sep 26, 2022 · 1 comment · Fixed by #2542
Closed

Feature: Code Review Check handle commits made by version bump bots #2302

joycebrum opened this issue Sep 26, 2022 · 1 comment · Fixed by #2542
Labels
kind/enhancement New feature or request

Comments

@joycebrum
Copy link
Contributor

joycebrum commented Sep 26, 2022

Is your feature request related to a problem? Please describe.

Discussion started at electron/electron#35741 (review)

Just oppening the discussion about the commits made automatically by some bots that, depending on its access rights and on its complexity, can not represent a big security risk.

We have some situations where it is not reasonable for the project to review every single commit made by the bot, since it is a very frequent and automatic job. But, by the other hand, allowing an ignore list for bots also leaves the door open to other projects excluding bots that might be more susceptible to compromise.

Describe the solution you'd like
The Code Review Check could handle, somehow, commits made by version bump bots, that just updates the version of the project itself, not of its dependencies.

Describe alternatives you've considered
I've consider to allow the user to exclude commits made by the bot, but this has the turnaround mentioned above of leaving the door open to other projects excluding bots that might be more susceptible to compromise.

Additional context
Add any other context or screenshots about the feature request here.

@raghavkaul
Copy link
Contributor

raghavkaul commented Sep 27, 2022

I think this likely regressed in #2260. Our new approach would be to check if the authors of a change were bots. Previously we used User.Login (API), but I think we should use User.Type instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
2 participants