🌱 Add Dart and Flutter CI systems to CI tests check. #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
requested review from
azeemshaikh38,
inferno-chromium,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
Integration tests success for |
|
Integration tests success for |
naveensrinivasan
added a commit
that referenced
this pull request
Jan 27, 2022
Fixed the gofmt issue for the PR #1548
The current check is looking at the github checks data to identify whether a given PR ran tests. Flutter and Dart repos are failing the check becuase their systems are not recognized as CI Systems. Bug: ossf#1547
godofredoc
force-pushed
the
add_flutter_ci
branch
from
20c055b to
145422b
Compare
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check is looking at the github checks data to identify whether a given PR ran tests. Flutter and Dart repos are failing the check because their systems are not recognized as CI Systems.
Bug: #1547
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Updates the CI Test check adding new CI Systems.
What is the current behavior? (You can also link to an open issue here)
Only common CI systems are included in the CI Test check and the ones used by Dart and Flutter are not included.
#1547
What is the new behavior (if this is a feature change)?
flutter-dashboard and Cirrus CI will now be recognized as CI systems running tests on the repositories' PRs
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: